Skip to content

Fix issue with sampling without replacement #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix issue with sampling without replacement #386

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3543a1
Fix issue with sampling without replacement
aristizabal95 Sep 26, 2024
9d916ed
Merge branch 'master' into master
aristizabal95 Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions csrc/cpu/neighbor_sample_cpu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,11 +325,11 @@ hetero_sample(const vector<node_t> &node_types,
} else {
// Sample without replacement:
unordered_set<int64_t> rnd_indices;
for (int64_t j = col_count - num_samples; j < col_count; j++) {
for (int64_t j = col_count - num_samples + 1; j < col_count + 1; j++) {
int64_t rnd = uniform_randint(j);
if (!rnd_indices.insert(rnd).second) {
rnd = j;
rnd_indices.insert(j);
rnd = j - 1;
rnd_indices.insert(rnd);
}
const int64_t offset = col_start + rnd;
const int64_t &v = row_data[offset];
Expand Down
Loading