Skip to content

Generate Deref assist for generic structs #20627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Generate Deref assist for generic structs #20627

wants to merge 1 commit into from

Conversation

phyBrackets
Copy link

@phyBrackets phyBrackets commented Sep 8, 2025 •
edited by rustbot
Loading

Fixing issue #20574

The fix ensures the assist correctly appears for generic structs without existing Deref implementations while maintaining accuracy for non-generic types.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 8, 2025
@A4-Tacks
Copy link
Contributor

A4-Tacks commented Sep 8, 2025

It seems that hir::Type::impls_trait behavior has changed recently.
Previously, it always returned false for generic types, but now it always returns true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phyBrackets @A4-Tacks @rustbot