Skip to content

Remove linters from test stage #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: rolling
Choose a base branch
from
Open

Remove linters from test stage #668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79f5f85
Resort deps
christophfroehlich Sep 3, 2025
a9a4404
Remove linters
christophfroehlich Sep 3, 2025
19c97c9
Remove empty BUILD_TESTING
christophfroehlich Sep 8, 2025
c4a9d99
Merge branch 'rolling' into rm_linters
christophfroehlich Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions gz_ros2_control/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,6 @@ install(DIRECTORY
DESTINATION include
)

# Testing and linting
if(BUILD_TESTING)
find_package(ament_lint_auto REQUIRED)
ament_lint_auto_find_test_dependencies()
endif()

ament_export_include_directories(include)
ament_export_libraries(${PROJECT_NAME}-system gz_hardware_plugins)

Expand Down
3 changes: 0 additions & 3 deletions gz_ros2_control/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@
<depend>hardware_interface</depend>
<depend>ros2_control_cmake</depend>

<test_depend>ament_lint_auto</test_depend>
<test_depend>ament_lint_common</test_depend>

<export>
<build_type>ament_cmake</build_type>
</export>
Expand Down
6 changes: 0 additions & 6 deletions gz_ros2_control_demos/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,6 @@ target_link_libraries(example_gripper PUBLIC
rclcpp::rclcpp
)

if(BUILD_TESTING)
find_package(ament_lint_auto REQUIRED)

ament_lint_auto_find_test_dependencies()
endif()

## Install
install(
TARGETS
Expand Down
5 changes: 1 addition & 4 deletions gz_ros2_control_demos/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
<build_depend>geometry_msgs</build_depend>
<build_depend>rclcpp</build_depend>
<build_depend>rclcpp_action</build_depend>
<build_depend>ros2_control_cmake</build_depend>
<build_depend>std_msgs</build_depend>

<exec_depend>ament_index_python</exec_depend>
Expand All @@ -35,7 +36,6 @@
<exec_depend>xacro</exec_depend>

<!-- ros2_control -->
<depend>ros2_control_cmake</depend>
<exec_depend>ackermann_steering_controller</exec_depend>
<exec_depend>control_msgs</exec_depend>
<exec_depend>diff_drive_controller</exec_depend>
Expand All @@ -51,9 +51,6 @@
<exec_depend>tricycle_steering_controller</exec_depend>
<exec_depend>velocity_controllers</exec_depend>

<test_depend>ament_lint_auto</test_depend>
<test_depend>ament_lint_common</test_depend>

<export>
<build_type>ament_cmake</build_type>
</export>
Expand Down
3 changes: 0 additions & 3 deletions gz_ros2_control_tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ project(gz_ros2_control_tests)
find_package(ament_cmake REQUIRED)

if(BUILD_TESTING)
find_package(ament_lint_auto REQUIRED)
ament_lint_auto_find_test_dependencies()

add_subdirectory(tests)
endif()

Expand Down
2 changes: 0 additions & 2 deletions gz_ros2_control_tests/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@
<buildtool_depend>ament_cmake</buildtool_depend>

<test_depend>ament_index_python</test_depend>
<test_depend>ament_lint_auto</test_depend>
<test_depend>ament_lint_common</test_depend>
<test_depend>gz_ros2_control_demos</test_depend>
<test_depend>launch_ros</test_depend>
<test_depend>launch_testing_ament_cmake</test_depend>
Expand Down