-
-
Notifications
You must be signed in to change notification settings - Fork 110
dannyhw/fix/nwui template issues #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dannyhw
wants to merge
8
commits into
main
Choose a base branch
from
dannyhw/fix/nwui-template-issues
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: update more dependencies fix: keep reanimted v3 for nativewind fix: keep reanimted v3 for nativewind fix fix: ensure we install 53 until we are ready to support 54 fix: tests should run fix: extra changeset fix: use reanimated 4 always run tests with node fix: ensure we install 53 until we are ready to support 54 chore(release): version packages fix: generating projects with yarn chore(release): version packages fix: tests fix fix: snapshots fix: extra comma breaking chore(release): version packages
fix: resolve TypeScript error in authentication select options fix: scripts
dannyhw
commented
Sep 19, 2025
screenOptions={{ | ||
tabBarActiveTintColor: 'black', | ||
}}> | ||
<Tabs> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was causing the icon to be barely visible in dark mode
dannyhw
commented
Sep 19, 2025
onPress={() => bottomSheetModalRef.current?.present()} | ||
/> | ||
<Sheet ref={bottomSheetModalRef} snapPoints={[200]}> | ||
<Sheet ref={bottomSheetModalRef} snapPoints={[200]} enableDynamicSizing={false}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixes bottom sheet not opening
01bc0c1
to
ede6be8
Compare
fix: tsc error fix: changeset
ede6be8
to
11b6e68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):