-
Notifications
You must be signed in to change notification settings - Fork 16
add SearXR to apps.md #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
added SearXR
typofix
I'm very intrigued, as I'm enthusiastic about both WebXR and remoteStorage, but it's not clear what your app does or how it works. I entered the URL of a .glb file, and it took me to the root page of the website. When you mention XR, it's not clear if the app is an XR app, or it's searching for XR experiences. The video is helpful, but not everyone will sit still for that long, and it only addressed the remoteStorage aspect. If you could add some documentation to orient users, that would help ensure users actually get something out of your app, and I'd feel better about including it in the list. |
Separately, I'm curious if you're looking for web pages with VirtualLocation metadata (https://schema.org/VirtualLocation). |
Thanks for trying. Perhaps you're talking only about the glb URL-viewer-usecase?
about entering GLB urls:
Unfortunately I don't have more resources to tailor/explain things beyond this PR. VirtualLocationThanks for pointing this out, I think I've seen this before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be really good to use the correct content type when storing JSON objects in a remote storage. This is automatically done when you use the storeObject()
function in rs.js, or you can add it via function argument when using storeFile()
(but you won't get object validation for free).
For example, in Inspektor, you can view and edit JSON documents in a special tree view/editor. But also, any other apps should also be able to detect that it's JSON content.
As a general recommendation, it's always a good idea to store things like the favorites in separate documents, because that's making it very safe to sync data without running into conflicts, when an app is used on more than one device, or data is accessed by more than one app.
rs.js makes that easy, too, e.g. if you store all of them in a /searxr/favorites/
folder, you can just use rsClient.getAll('searxr/favorites/')
to load all of the objects at once.
good points. TBH: this PR is just a markdown file with an extra link of RS-usage, because I think it will help grow RS.
|
change category WebXR to searxr Co-authored-by: Râu Cao <842+raucao@users.noreply.github.com>
I think the terms "deep" and "audit" are not accurate here. I simply tried out the most basic function of the app and looked at the stored data. The first thing I saw was an actual mistake in the listing, which I provided a correction for, that takes one click to commit. Then, when I saw that the app is using the protocol wrong on a very basic level (content types are a corner stone of sharing data between any apps), I added this to my PR review, including pointers for solutions, and without requiring changes to be made. I also immediately ran into the sync not working correctly (it failed to remove all the bookmarks when I quickly deleted everything I hadn't explicitly stored myself), upon which I provided a recommendation for a best practice that avoids this entire class of bugs. I can see that it's frustrating to submit a link, only for people to find various issues with your new app. However, if the first two users trying out the app immediately have issues when using it, then don't you think other users coming from the Apps page will also have issues? Also, you're getting free testing and reviews from experienced devs here, which is honestly something I'm personally incredibly grateful for when I publish my own code on the Web. As stated before, the basic requirement for an app to be listed is merely that it's clear for a user how they can store and access data, and that it's not outright broken. Everything else is just free help to improve users' experiences, as well as interop in the ecosystem. |
I politely disagree with the premise that I was asking for an 'free' sourcecode-review/consult. Final thoughts: many thoughts and questions are reasonable in this PR-review, but kind request to use this issuetracker instead from here on. For a PR of this repo, I (and probably more future RS-adopters) come from this angle:
The last 2 points seem to go against this (and previous) PR process. Perhaps an |
demo/usage:
https://blog.searxr.me/30%20code/remotestorage.html
https://id.420129.xyz/watch?v=R3IW945yhU4