ENH: make fitz_doc_to_image approximate dpi_target while satisfying contraints #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onstraints Refactor fitz_doc_to_image function to accept to not fallback to 72DPI if target dpi is too high but try to match it as close at possible.
AdamCodd
added a commit
to AdamCodd/dots.ocr
that referenced
this pull request
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors and enhances the
fitz_doc_to_imagefunction indots_ocr/utils/doc_utils.py.Before, if applying the target_dpi would result in an image bigger than allowed by constraints (4500 height/width) was reset to 72 kpi, lower than the default. Now it tries to find the highest value that satisfy the constraints