Skip to content

Conversation

ggivo
Copy link
Collaborator

@ggivo ggivo commented Oct 8, 2025

Add profile for scenario tests and improve test separation

Summary

This PR improves Maven test execution configuration by:

  1. Adding proper skip properties for unit tests, integration tests, and scenario tests
  2. Creating a dedicated Maven profile for running scenario tests
  3. Fixing Failsafe plugin configuration to properly handle scenario tests in the scenario package
  4. Adding @Tag("scenario") to ConnectionInterruptionTest for consistency

Usage Examples

Run Only Unit Tests

mvn clean test

Run Unit Tests + Integration Tests (Default)

mvn clean verify

This runs:

  • ✅ Unit tests (via Surefire)
  • ✅ Integration tests tagged with @Tag("integration") (via Failsafe)
  • ✅ Integration tests with *IntegrationTest.java suffix (via Failsafe)
  • ❌ Scenario tests (skipped by default)

Run Only Scenario Tests

mvn -Pscenario-tests clean verify

This runs:

  • ❌ Unit tests (skipped)
  • ❌ Integration tests (skipped)
  • ✅ Scenario tests tagged with @Tag("scenario") (via Failsafe)

Scenario tests include:

  • ActiveActiveFailoverIT
  • ClusterTopologyRefreshIT
  • ConnectionInterruptionIT
  • LagAwareStrategySslIT
  • RedisRestAPIIntegrationIT

Test

  • Tested by comparing the test's run number in this PR agains the number of tests run in earlier runs against master branch

  to run only scenario tests
  mvn -Pscenario-tests clean verify

# Conflicts:
#	src/test/java/redis/clients/jedis/mcf/ActiveActiveLocalFailoverTest.java
#	src/test/java/redis/clients/jedis/scenario/ActiveActiveFailoverIT.java
@ggivo ggivo force-pushed the ggivo/run-scenario-tests branch from 56a774b to 2e429db Compare October 8, 2025 14:20
Copy link

github-actions bot commented Oct 8, 2025

Test Results

   282 files   - 1     282 suites   - 1   11m 37s ⏱️ ±0s
10 075 tests ±0  10 030 ✅ ±0  45 💤 ±0  0 ❌ ±0 
 2 713 runs  ±0   2 713 ✅ ±0   0 💤 ±0  0 ❌ ±0 

Results for commit 8162f36. ± Comparison against base commit 6a4a94b.

♻️ This comment has been updated with latest results.

@ggivo ggivo added maintenance skip-changelog Ignore pull request from release note churn Chore: Formatting and comment cleanup (non-functional change) labels Oct 8, 2025
@uglide
Copy link
Contributor

uglide commented Oct 8, 2025

Testcase Errors Failures Skipped Total
redis.clients.jedis.scenario.ClusterTopologyRefreshIT 0 0 0 1
redis.clients.jedis.scenario.ActiveActiveFailoverIT 1 0 0 1
redis.clients.jedis.scenario.LagAwareStrategySslIT 3 0 0 10
redis.clients.jedis.scenario.ConnectionInterruptionIT 0 0 0 4
redis.clients.jedis.mcf.RedisRestAPIIT 0 2 0 2

---- Details for maintainers

@ggivo ggivo marked this pull request as ready for review October 8, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
churn Chore: Formatting and comment cleanup (non-functional change) maintenance skip-changelog Ignore pull request from release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants