chore(test): improve robustness of the rh login workflow via browser #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odockal
force-pushed
the
issue-759
branch
3 times, most recently
from
5b889eb to
94e1e84
Compare
jeffmaury
reviewed
Apr 29, 2025
tests/src/utility/auth-utils.ts
Outdated
| await playExpect(buttonRHAccount).toBeVisible({ timeout: 5000 }); | ||
| await buttonRHAccount.click(); | ||
| } catch (error: unknown) { | ||
| console.log(`Error: ${error}, while evaluating Log in with RH acc. button, continue...`); |
There was a problem hiding this comment.
We are swallowing the error is that one purpose ?
There was a problem hiding this comment.
Yes, I do not know what button gonna be there and why. If you inserts your username and click next, you are either going directly to password input or, you got to choose from if to use red hat account or sso, then password. There is no other reliable construct how to do it without try catch...
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #759