Skip to content

Revert "Log Stream rwops errors and prevent opening Stream if null" #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Revert "Log Stream rwops errors and prevent opening Stream if null" #46

wants to merge 1 commit into from

Conversation

@glebm
Copy link
Contributor

@glebm glebm commented Aug 31, 2025 •
edited
Loading

This reverts commit b2df2df.

Custom decoders do not always use rwops, so this check was incorrect.
For example, we have a PushAulibDecoder that doesn't use rwops: https://github.com/diasurgical/DevilutionX/blob/master/Source/utils/push_aulib_decoder.h

Fixes #44

@glebm
Revert "Log Stream rwops errors and prevent opening Stream if null"
6c5c6b6 
This reverts commit b2df2df.

Custom decoders do not always use `rwops`, so this check was incorrect.

Fixes realnc#44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SDL_Audiolib incorrectly checks for d->fRWops even for non-RWOps streams

1 participant

@glebm