feat: Improved logging performance by replacing regular expression #4121
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th indexOf and substring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves performance for those using the logging operations of Reactor.
The old implementation used
String#replaceFirstas it's method to replace the package name with an empty String. AsreplaceFirstaccepts a regular expression, the evaluation was more expensive.The new logic utilizes a simple substring search and doesn't create an unnecessary new String, but directly appends to the StringBuilder.
Additionally each dot (
.) in the package's name, including the appended dot at the end, was treated as a wildcard, which is unexpected behaviour (i assume).