- 
                Notifications
    You must be signed in to change notification settings 
- Fork 645
[RayService] Rollback Support for Incremental Upgrades #4109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Draft
      
      
            ryanaoleary
  wants to merge
  29
  commits into
  ray-project:master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
ryanaoleary:rollback-support
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Update go mod dependencies for gateway v1 Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Add reconcile Gateway and HTTPRoute Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Add TargetCapacity and TrafficRoutedPercent to RayServiceStatus Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Add controller logic initial commit Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Add IncrementalUpgrade check to ShouldUpdate Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Update controller logic to reconcile incremental upgrade Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> TrafficRoutedPercent should not set default value Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Remove test changes to TPU manifest Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Move helper function to utils Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Fix lint Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Fix field alignment Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Fix bad merge Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Fix CRDs and add validation test case Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Test create HTTPRoute and create Gateway Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Add reconcile tests for Gateway and HTTPRoute Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Fix lint Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Add tests for util functions and fix golangci-lint Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Add basic e2e test case Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Fix GetGatewayListeners logic and test Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Add gatewayv1 scheme to util runtime Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Check if IncrementalUpgrade is enabled before checking Gateway Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Fix reconcile logic for Gateway and HTTPRoute Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Add feature gate Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Always create Gateway and HTTPRoute for IncrementalUpgrade Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Fix target_capacity reonciliation logic Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Add additional unit tests Signed-off-by: Ryan O'Leary <ryanaoleary@google.com> Move e2e test and add another unit test Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Co-authored-by: Han-Ju Chen (Future-Outlier) <eric901201@gmail.com> Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
Co-authored-by: Han-Ju Chen (Future-Outlier) <eric901201@gmail.com> Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
Co-authored-by: Han-Ju Chen (Future-Outlier) <eric901201@gmail.com> Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Co-authored-by: Han-Ju Chen (Future-Outlier) <eric901201@gmail.com> Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
Co-authored-by: Han-Ju Chen (Future-Outlier) <eric901201@gmail.com> Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
Co-authored-by: Han-Ju Chen (Future-Outlier) <eric901201@gmail.com> Signed-off-by: Ryan O'Leary <113500783+ryanaoleary@users.noreply.github.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
| cc: @Future-Outlier the changes for full rollback support are just in this commit: f5d0243 | 
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Why are these changes needed?
Implement rollback support for the IncrementalUpgrade RayService feature.
Related issue number
#3209
Checks