Onboarding Molmo Model #554
Open
+1,064
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohiso22
requested review from
quic-rishinr,
ochougul,
quic-hemagnih and
quic-amitraj
as code owners
quic-amitraj
reviewed
Sep 9, 2025
| **kwargs, | ||
| ) -> Tuple[torch.Tensor, Optional[Tuple[torch.Tensor, torch.Tensor]]]: | ||
| if not self.config.norm_after: | ||
| if self._activation_checkpoint_fn is not None: |
There was a problem hiding this comment.
Remove all the training related code throughout this file.
quic-amitraj
requested changes
Sep 9, 2025
mohiso22
force-pushed
the
molmo
branch
2 times, most recently
from
4156fd1 to
2c9e1b4
Compare
added 2 commits
October 6, 2025 06:25
Signed-off-by: Mohit Soni <mohisoni@qti.qualcomm.com>
Signed-off-by: Mohit Soni <mohisoni@qti.qualcomm.com>
quic-xiyushi
reviewed
Oct 8, 2025
|
|
||
| img_size = 588 | ||
| img_tile = 576 | ||
| num_images = 5 |
There was a problem hiding this comment.
Could you make num_images a parameter instead of hardcoding it? The value of num_images here is essentially max_crops (which is one of the image processor kwargs) plus 1. That way, in VLLM, we can apply the same preprocessing logic as we do for llama4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.