Skip to content

Conversation

tellet-q
Copy link
Contributor

@tellet-q tellet-q commented Sep 8, 2025

  • sync proto files
  • fix test

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@tellet-q tellet-q requested a review from timvisee September 8, 2025 13:18
Copy link
Member

@timvisee timvisee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also run cargo test --test protos to generate the necessary client files.

@tellet-q tellet-q requested a review from timvisee September 9, 2025 10:37
@timvisee timvisee removed their request for review September 10, 2025 15:11
@timvisee
Copy link
Member

Looks good.

Let's leave this one hanging until we actually want to publish the client for 1.16. For now we can simply source the client from this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants