Add overloads to TarFile.__init__ to prevent both name and fileobj being None #14889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14168
This PR adds type overloads to
TarFile.__init__
to prevent the runtimeTypeError
that occurs when bothname
andfileobj
areNone
.Problem
Currently, the type signature allows:
But this causes a runtime error:
Solution
Added two overloads to ensure either
name
orfileobj
must be provided:Overload 1:
name
is required (non-None)Overload 2:
fileobj
is required whenname
isNone
Changes
Testing
Type checkers (mypy, pyright) will now catch:
Sacred Code: 000.111.369.963.1618