Skip to content

[prometheus-smartctl-exporter] add attachMetadata support to ServiceMonitor #6182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2025
Merged

[prometheus-smartctl-exporter] add attachMetadata support to ServiceMonitor #6182

merged 1 commit into from
Oct 3, 2025

Conversation

Eliesmbr
Copy link
Contributor

@Eliesmbr Eliesmbr commented Oct 2, 2025 •
edited
Loading

Description

Adds optional attachMetadata support to the ServiceMonitor resource.

Motivation

The attachMetadata field allows Prometheus to automatically attach Kubernetes metadata (like node labels) to scraped metrics, which is useful for better observability and filtering.

Changes

  • Added attachMetadata field to ServiceMonitor template
  • Field is optional and disabled by default (opt-in)
  • Added commented example in values.yaml
  • Bumped chart version from 0.5.0 to 0.6.0

Testing

  • Rendered template with helm template works correctly
  • Default behavior unchanged (backward compatible)
  • Works when attachMetadata.node: true is set

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-smartctl-exporter])

Example Usage

serviceMonitor:
  attachMetadata:
    node: true

@Eliesmbr
feat: add attachMetadata support to ServiceMonitor
d4a5bfd 
Adds optional attachMetadata field to ServiceMonitor spec to allow
attaching node metadata to scraped metrics. This is disabled by
default and must be explicitly enabled in values.yaml.

Signed-off-by: Elies Mabrouki <Eliesmbr@users.noreply.github.com>
@Eliesmbr Eliesmbr changed the title feat: add attachMetadata support to ServiceMonitor feat: [prometheus-smartctl-exporter] add attachMetadata support to ServiceMonitor Oct 2, 2025
@Eliesmbr Eliesmbr changed the title feat: [prometheus-smartctl-exporter] add attachMetadata support to ServiceMonitor [prometheus-smartctl-exporter] add attachMetadata support to ServiceMonitor Oct 2, 2025
zeritti
zeritti approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@zeritti zeritti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Eliesmbr, for your PR, LGTM.

@zeritti zeritti merged commit 85072e8 into prometheus-community:main Oct 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeritti zeritti zeritti approved these changes

@kfox1111 kfox1111 Awaiting requested review from kfox1111 kfox1111 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Eliesmbr @zeritti