Format ejabberd source code using efmt #4452
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ejabberd 24.06 introduced experimental support for
make format
using Rebar3 +rebar3_format
and support formake indent
using Emacs +erlang-mode
. Both of them are optional, and applied in small portions of the ejabberd source code.The corresponding documentation was added to the Docs site, including an explanation to format automatically when running
git push
Unfortunately
rebar3_format
is now marked as "archived", so it is time to look for an active replacement.Nowadays I have found two erlang source code formatters:
In some cases that none of them achieves an acceptable formatting, we can use emacs indentation.
This PR:
make format
to use efmtRight now this is a proposal. Please comment alternatives, ideas, problems that you found...