-
Notifications
You must be signed in to change notification settings - Fork 116
Update openvm to 1.4.0 #3291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
qwang98
wants to merge
165
commits into
main
Choose a base branch
from
ovm-1.4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update openvm to 1.4.0 #3291
Changes from 6 commits
Commits
Show all changes
165 commits
Select commit
Hold shift + click to select a range
e1e783a
fixed hints-circuit
Schaeff 2cfe4e3
wip
Schaeff 21ad1e7
first commit but chip inventory doesn't seem to work
qwang98 26e31c4
add exeutor complex, but seems that we can get airs from chip complex…
qwang98 04508d5
managed to get airs via executor inventory -> air inventory -> air re…
qwang98 33efc8e
fix sdk calls
Schaeff a36b3a2
Merge pull request #3292 from powdr-labs/ovm-1.4-get-original-airs
Schaeff dcb0293
Merge branch 'ovm-1.4' of github.com:powdr-labs/powdr into ovm-1.4
Schaeff 0c3dd22
add flag
Schaeff 9596cc7
patch bus map
qwang98 c0da8f8
Merge pull request #3294 from powdr-labs/ovm-1.4-extraction-utils
Schaeff 14229da
make compile
Schaeff 3269e55
pull main, make compile
Schaeff d1e2a22
export_pil wip
Schaeff aab0dfd
pull main
Schaeff 85f35d0
make pil export test pass
Schaeff 3724813
implement VmExecutionExtension and VmExecutionConfig for some types
qwang98 e276b89
add some vmcircuit implementations
qwang98 3f37dc2
solve AnyRap trait bounds
qwang98 7c3d7aa
add asref<systemconfig> and asmut<systemconfig> impls
qwang98 ad65a11
remove executor_inventory() function in place of create_executors()
qwang98 78752fd
give PowdrExtension access to ChipComplex via OriginalVmConfig
qwang98 d2571c8
Merge pull request #3298 from powdr-labs/ovm-1.4-extend-executor
Schaeff 2ff7ce1
create sdk with the correct config
Schaeff 4b3d8f9
simplify executor
Schaeff 189d9de
switch to SdkVmConfig for the dummy inventory, implement it
Schaeff 3d0ff0c
implement prover extension
Schaeff 4bf21e6
create_chip_complex
qwang98 7d1c5f9
fixed executor::new() error via injecting dummy airs and now panic ag…
qwang98 47d1bb0
remove prints
qwang98 864e93c
remove more comments
qwang98 e9a80e9
Merge pull request #3300 from powdr-labs/ovm-1.4-memory-2
Schaeff a1a8d40
only add TODO after studying the code; not implemented yet
qwang98 08c894c
keep only executor impls for PowdrExecutor
Schaeff 5834bf7
clippy, fmt
Schaeff 287f34e
PhantomExecutor
Schaeff 57cd49d
import, remove unimplemented
Schaeff 72b4171
remove mutex
Schaeff 7aea878
merge ovm-1.4
qwang98 b8720e2
precompute size
qwang98 c6b6c17
fmt
qwang98 ed27104
added some notes for meteredexecutor and executor. they don't seem to…
qwang98 6077b02
execute implementation (for Preflight and need to move over next)
qwang98 1236462
clean up comments
qwang98 e64ed22
add a small comment for Preflight
qwang98 0445fb2
Merge pull request #3302 from powdr-labs/ovm-1.4-tracegen
Schaeff fe7d918
make test pass because apcs are not run
Schaeff 8f3a49a
add apc to the program
Schaeff 04a260f
first commit with full impl for execution and metered execution
qwang98 191aef2
added preflight implementation, but blocked by a few TODOs
qwang98 462ccbc
bug fix: use curr_pc instead of pc
qwang98 a837b8c
fix some comments
qwang98 172409d
implement e1 and e2 with a derived AlignedBytesBorrow
Schaeff 1e3e47a
clean up
Schaeff 491b632
clean
Schaeff a18f82b
comment fixes
qwang98 d1f1c7c
Merge pull request #3310 from powdr-labs/ovm-1.4-execution-with-deriv…
qwang98 815dd47
use refcells for mutable fields of PowdrExecutor (dummy recod arena a…
qwang98 7827f09
complete trace gen but not debugged at all
qwang98 4f8edcc
bug fix: not all record arenas have dummy traces
qwang98 16461c9
modify program when adding apcs
Schaeff 0617a00
Merge pull request #3311 from powdr-labs/modify-program-fix
Schaeff 5b5db0a
Merge branch 'ovm-1.4' of github.com:powdr-labs/powdr into ovm-1.4-al…
Schaeff 440c271
Merge pull request #3309 from powdr-labs/ovm-1.4-all-execution-modes
Schaeff 4ccec33
first commit but test still fails at proving
qwang98 ab10057
first commit with mock prover, test prints debug message on bus
qwang98 f2f7425
clean up
qwang98 ae0e785
Merge pull request #3317 from powdr-labs/ovm-1.4-mock-prover
Schaeff 57180c2
clean hints-circuit executors
Schaeff ff27118
Merge branch 'main' of github.com:powdr-labs/powdr into ovm-1.4
Schaeff 675176d
fix some of the comments
qwang98 00601e8
made RA dimension a struct
qwang98 eda50b5
clean up
Schaeff b0ac0d9
pull target
Schaeff ad0f4b5
more cleaning
Schaeff 9ecf44c
decouple chip and executor
Schaeff 6f91298
Merge pull request #3321 from powdr-labs/ovm-1.4-decouple
Schaeff ac5b415
first commit
qwang98 bfe1d86
remove some comments/prints
qwang98 f791df2
implemented single Vec<RA> at initialization; trace gen now works
qwang98 f9addcd
removed cached original instruction count and fixed comments
qwang98 283f080
Merge pull request #3325 from powdr-labs/ovm-1.4-decouple-3
Schaeff 7df1ce1
Merge branch 'ovm-1.4' into ovm-1.4-fix-dummy-trace
Schaeff 54d39f0
Merge pull request #3316 from powdr-labs/ovm-1.4-fix-dummy-trace
Schaeff f49c4bd
pull target
Schaeff 7496c8e
simplify
Schaeff 8fddb45
introduce trace_generator, re-introduce plonk, clean up
Schaeff 69cefba
use number_of_calls() in plonk chip
qwang98 716b797
Merge pull request #3318 from powdr-labs/ovm-1.4-cleanup
qwang98 41b6aa3
fixed simple fibo test, which panic'ed with original not found becaus…
qwang98 e13688f
fix second bug on plonk air
qwang98 4afaede
fixed third bug: air_metrics shouldn't use chip complex without any p…
qwang98 8dbcfd2
fixed fourth bug on all tests with more than 1 apc
qwang98 1902bf3
remove prits
qwang98 42ed94b
fixed comments
qwang98 81091cc
fix comments
qwang98 bdda298
Merge pull request #3326 from powdr-labs/ovm-1.4-test-bug-fix
Schaeff be9ca33
put back logup col count
Schaeff 096b9bc
fix log up and update expected
qwang98 e8e0c0d
also fix max columns
qwang98 7708fd3
remove some commetns
qwang98 a6453d2
fix instret, fix multisegment
Schaeff 91d6736
pull target
Schaeff eaa8283
fmt
Schaeff 452481f
fmt
Schaeff 7eef8b6
fmt
Schaeff c47561a
columnsair fix
qwang98 ad2d461
update k256 openvm dependency to 1.4.0-wip
qwang98 4234175
first commit with attempt to use sdk for extendedVMConfig, but encoun…
qwang98 9b12547
added a bunch of print statements to aid testing
qwang98 75d25e0
udpate k256 dependency for ecc-powdr-affine-hint
qwang98 e2dc162
Merge pull request #3329 from powdr-labs/ovm-1.4-test-fix-bug-2
Schaeff 907a0bf
memory AS is now stored as u8 instead of F
pacheco 4c5f4eb
Merge pull request #3332 from powdr-labs/ovm-1.4-hints-memory-fix
qwang98 058f2ef
remove some prints and panics
qwang98 8ad34a4
remove more prints
qwang98 7a09cb4
Merge pull request #3331 from powdr-labs/ovm-1.4-fix-execution-profil…
Schaeff 94dc325
ignore keccak plonk test due to debug assertion bug
qwang98 5dcbb34
Merge branch 'main' of github.com:powdr-labs/powdr into ovm-1.4
Schaeff a8d8fbf
clean
Schaeff 0b35edf
clean
Schaeff ddc1309
pull target
Schaeff 3260408
lock stark backend and ovm
Schaeff fa84893
use reth compatible serde version for powdr-openvm-hints-circuit
qwang98 5d34a76
add support for tco and metrics by adding features
Schaeff c800f49
update ovm to log pc in tco mode
Schaeff c6a13e6
update nightly
Schaeff 8ab376d
update rust toolchain more
Schaeff c37f3f9
clippy
Schaeff f72f8e5
fmt
Schaeff 6d4b3b7
try fix reth test
Schaeff 180027f
typo
Schaeff e88c853
fix ref
Schaeff 274c73b
add log
Schaeff d32a136
expose HintsExtension
Schaeff 6a147f4
update reth
Schaeff ad00797
fmt
Schaeff a4f438f
update reth
Schaeff 63191ff
update k256
Schaeff 9de513b
update dep
Schaeff e854c9f
run only one test
Schaeff 5885b92
run cargo test
Schaeff 70169b3
enable logs and debug, run only one test
Schaeff 26fe978
run more tests, use pr-test profile
Schaeff ffa9419
revert, single job matrix
Schaeff 2ee1142
remove all-features
Schaeff 21bd511
remove tco
Schaeff ca3ff63
point to reth without tco
Schaeff 055b6fb
revert ci
Schaeff e5d9993
enable tco
Schaeff 3a1dacd
update reth
Schaeff 2139f4e
update k256
Schaeff 6b3e266
address review comment about record_arena_dimension_by_air_name_per_a…
Schaeff 5b1f359
typo
Schaeff f69b675
address review comments
Schaeff 7d2d9a0
remove ignore as test passes
Schaeff 9975ee6
refine plonk error, add test, fix height change
Schaeff e4730ef
Merge branch 'main' of github.com:powdr-labs/powdr into ovm-1.4
Schaeff a1a84d9
ignore tests, add reason
Schaeff d3da73c
pull main
Schaeff d0e6c3c
fix review comments
Schaeff 99651ba
pull main
Schaeff cbef8b2
fix cargo.toml
Schaeff 6ab6e42
fix metrics collection in cli
Schaeff 0546cfa
make metrics default in openvm-cli
Schaeff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.