Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions constraints.txt
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ collective.recipe.vscode==0.1.9
collective.xmltestreport==2.0.2
icalendar==6.3.1
Products.DateRecurringIndex==3.0.1
robotsuite==2.3.2
five.customerize==4.0
Products.CMFCore==3.7
Products.CMFUid==4.2
Expand Down Expand Up @@ -227,19 +226,20 @@ requests-toolbelt==1.0.0
responses==0.25.7
rfc3986==2.0.0
rich==14.0.0
robotframework==6.0.2
robotframework==7.3.2
robotframework-assertion-engine==3.0.3
robotframework-browser==19.3.1
robotframework-browser==19.8.0
robotframework-debuglibrary==2.5.0
robotframework-lsp==1.10.1
robotframework-lsp==1.13.0
robotframework-pythonlibcore==4.4.1
robotframework-selenium2library==3.0.0
robotframework-selenium2screenshots==0.8.1
robotframework-seleniumlibrary==6.1.3
robotframework-seleniumlibrary==6.7.1
robotframework-seleniumtestability==2.1.0
robotsuite==3.0.0
rpds-py==0.22.3
SecretStorage==3.3.3
seedir==0.5.0
seedir==0.5.1
selenium==4.9.1
sgmllib3k==1.0.0
simplejson==3.20.1
Expand Down
4 changes: 1 addition & 3 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,4 @@ pywin32 ; platform_system == 'Windows'
certifi ; platform_system == 'Windows'

# VSCode robotframework-lsp requires robotframework directly in venv
robotframework==6.0.2
# robotframework >= 6.1 is only supported with robotframwork-lsp >= 1.11.0,
# but https://github.com/robocorp/robotframework-lsp/issues/947
robotframework==7.3.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR, I don't like that this is in requirements.txt. It ends up on dist.plone.org/release, so lots of projects that directly use the requirements.txt will install robotframework needlessly.

I would keep it here in 6.1, but would be in favour of removing it in coredev 6.2.

Mind you, I don't do much with robot tests, and I don't think I have the VS code extension for it installed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also do not use VSCode plugin ... @datakurre added this to requirements.txt but I'm fine with removing it again for 6.2

15 changes: 7 additions & 8 deletions versions.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ collective.recipe.vscode = 0.1.9
collective.xmltestreport = 2.0.2
icalendar = 6.3.1
Products.DateRecurringIndex = 3.0.1
robotsuite = 2.3.2

# CORE DEPENDENCIES: Zope and friends
# These packages are what you get when installing Plone,
Expand Down Expand Up @@ -263,21 +262,21 @@ requests-toolbelt = 1.0.0
responses = 0.25.7
rfc3986 = 2.0.0
rich = 14.0.0
robotframework = 6.0.2
# robotframework >= 6.1 is only supported with robotframwork-lsp >= 1.11.0,
# but https://github.com/robocorp/robotframework-lsp/issues/947
robotframework = 7.3.2
robotframework-assertion-engine = 3.0.3
robotframework-browser = 19.3.1
robotframework-browser = 19.8.0
robotframework-debuglibrary = 2.5.0
robotframework-lsp = 1.10.1
robotframework-lsp = 1.13.0
robotframework-pythonlibcore = 4.4.1
# core tests do not use selenium anymore -> remove?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could keep it here, but remove the pins in coredev 6.2.

robotframework-selenium2library = 3.0.0
robotframework-selenium2screenshots = 0.8.1
robotframework-seleniumlibrary = 6.1.3
robotframework-seleniumlibrary = 6.7.1
robotframework-seleniumtestability = 2.1.0
robotsuite = 3.0.0
rpds-py = 0.22.3
SecretStorage = 3.3.3
seedir = 0.5.0
seedir = 0.5.1
selenium = 4.9.1
sgmllib3k = 1.0.0
simplejson = 3.20.1
Expand Down
Loading