Skip to content

Allow to change autocommit attribute #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow to change autocommit attribute #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion sqlitedict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ def reraise(tp, value, tb=None):
#
_REQUEST_CLOSE = '--close--'
_REQUEST_COMMIT = '--commit--'
_REQUEST_AUTOCOMMIT = '--autocommit--'
_RESPONSE_NO_MORE = '--no more--'

#
Expand Down Expand Up @@ -210,7 +211,7 @@ def __init__(self, filename=None, tablename='unnamed', flag='c',
# See https://github.com/RaRe-Technologies/sqlitedict/pull/113
self.tablename = tablename.replace('"', '""')

self.autocommit = autocommit
self._autocommit = autocommit
self.journal_mode = journal_mode
self.encode = encode
self.decode = decode
Expand All @@ -231,6 +232,15 @@ def __init__(self, filename=None, tablename='unnamed', flag='c',
if flag == 'w':
self.clear()

@property
def autocommit(self):
return self._autocommit

@autocommit.setter
def autocommit(self, value):
self._autocommit = value
self.conn.select_one(_REQUEST_AUTOCOMMIT, (value,))

def _new_conn(self):
return SqliteMultithread(
self.filename,
Expand Down Expand Up @@ -513,6 +523,13 @@ def run(self):
if req == _REQUEST_CLOSE:
assert res_ref, ('--close-- without return queue', res_ref)
break
elif req == _REQUEST_AUTOCOMMIT:
self.autocommit = arg[0]
if self.autocommit:
conn.isolation_level = None
else:
conn.isolation_level = ""
_put(res_ref, _RESPONSE_NO_MORE)
elif req == _REQUEST_COMMIT:
conn.commit()
_put(res_ref, _RESPONSE_NO_MORE)
Expand Down