Skip to content

Reverb wrapping bugfix #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Reverb wrapping bugfix #33

wants to merge 3 commits into from

Conversation

@djtuBIG-MaliceX
Copy link

Address Issue #16

  • Fix integer overflow wrapping causing audio distortion for loud resulting signals with reverb enabled.

@djtuBIG-MaliceX djtuBIG-MaliceX mentioned this pull request Jan 6, 2021
Open
djtuBIG-MaliceX
djtuBIG-MaliceX commented Jan 6, 2021
View reviewed changes
Copy link
Author

@djtuBIG-MaliceX djtuBIG-MaliceX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like some thoughts from anyone else. While this will address the immediate integer overflow distortion issue as tested, it does not address other deficiencies such as the fact stereo signals are downmixed to mono reverb.

src/synth/constants.h

#ifdef _WIN32
#define snprintf _snprintf
//#define snprintf _snprintf
Copy link
Author

@djtuBIG-MaliceX djtuBIG-MaliceX Jan 6, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to comment this out as it was failing to build under MSYS2 MinGW-w64. This seems like a dirty hack anyway that likely no longer applies with more recent versions of MinGW-w64 GCC compiler suite.

src/synth/reverb.cpp
in1 = smp;
smp = ou0>>2;

b[i] = (smp > INT_MAX) ? INT_MAX :
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking more work might be needed to prevent double-clipping.

djtuBIG-MaliceX
djtuBIG-MaliceX commented Jan 6, 2021
View reviewed changes
src/synth/reverb.cpp
b[i] = ou0l;
ou0l = ((smp * a0)/32768) + ((in1l * a1)/32768) + ((ou0l * b1)/32768);
in1l = smp;
b[i] = (ou0l > INT_MAX) ? INT_MAX :
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, this may contribute to double-clipping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@djtuBIG-MaliceX