Refactor config/resolvers.go, update resolvers_test.go #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `BenchmarkTestConfigSetResolvers` added - Refactored testing functions in resolvers_test.go
- Moved functionality of AddResolvers and AddResolver methods into SetResolvers method - Moved functionality of AddTrustedResolvers and AddTrustedResolver methods into SetTrustedResolvers method - Modified where SetTrustedResolvers method calls AddResolvers, is now calling AddTrustedResolvers in it's place. - Additional tests for SetTrustedResolvers added to resolvers_test.go
|
Any recommendations for changes to this PR? |
Codecov Report
@@ Coverage Diff @@
## develop #814 +/- ##
===========================================
+ Coverage 39.46% 40.12% +0.66%
===========================================
Files 42 42
Lines 5307 5295 -12
===========================================
+ Hits 2094 2124 +30
+ Misses 3115 3070 -45
- Partials 98 101 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @caffix
config/resolvers_test.goto improve code coverage for methods inconfig/resolvers.goAddResolversandAddResolvermethods intoSetResolversAddTrustedResolversandAddTrustedResolvermethods intoSetTrustedResolvers