Skip to content

feat(theme-generator): implement the component inside Storybook with … #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(theme-generator): implement the component inside Storybook with … #935

wants to merge 3 commits into from

Conversation

var-poro
Copy link
Contributor

@var-poro var-poro commented Oct 2, 2025

…corresponding stories

@var-poro var-poro requested a review from a team as a code owner October 2, 2025 12:22
dpellier
dpellier requested changes Oct 2, 2025
View reviewed changes
package.json
"@types/scheduler": "< 0.23.0"
}
},
"packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

packages/themes/src/developer/default.scss
@@ -0,0 +1,17 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBD - shall all new themes extend default and only overrides what they need?

packages/storybook/src/components/themeGenerator/ThemeGenerator.tsx
import * as ODSReact from '@ovhcloud/ods-react';
import { ORIENTATION, OrientationSwitch } from '../sandbox/actions/OrientationSwitch';
import styles from './themeGenerator.module.css';
import { ThemeGeneratorTreeView } from './themeGeneratorTreeView/ThemeGeneratorTreeView';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename the directory to match this (there is a capital letter on the actual dir, this breaks the CI deployement)

@var-poro var-poro force-pushed the feat-theme-generator branch 3 times, most recently from b556d46 to decd45f Compare October 2, 2025 14:43
@var-poro var-poro force-pushed the feat-theme-generator branch from decd45f to aaa2dbd Compare October 3, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpellier dpellier dpellier requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@var-poro @dpellier