Skip to content

Conversation

dafedafe
Copy link
Contributor

@dafedafe dafedafe commented Sep 12, 2025

After JDK-8260555 changed the default TIMEOUT_FACTOR from 4 to 1 the compiler/startup/StartupOutput.java test doesn't always complete within the timeout period of 2 minutes on Windows platform.

Instead of increasing the timeout for this test, this change reduces the number of times StartupOutput.java runs the vm with randomly-generated close-to-minimum code-cache size from 200 to 100, which should be more than enough attempts.

Testing: tiers 1-3+


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8367278: Test compiler/startup/StartupOutput.java timed out after completion on Windows (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27254/head:pull/27254
$ git checkout pull/27254

Update a local copy of the PR:
$ git checkout pull/27254
$ git pull https://git.openjdk.org/jdk.git pull/27254/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27254

View PR using the GUI difftool:
$ git pr show -t 27254

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27254.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2025

👋 Welcome back dfenacci! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 12, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8367278: Test compiler/startup/StartupOutput.java timed out after completion on Windows 8367278: Test compiler/startup/StartupOutput.java timed out after completion on Windows Sep 12, 2025
@openjdk
Copy link

openjdk bot commented Sep 12, 2025

@dafedafe The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

1 participant