Skip to content

Conversation

psrigummadidala
Copy link

https://2u-internal.atlassian.net/browse/PROD-4397
Description:

This PR includes the following changes:

Upgraded React and React DOM from version 17 to 18.
Removed Enzyme and related dependencies (enzyme, enzyme-adapter-react-16, etc.).
Rewritten all unit tests using React Testing Library to align with React 18 best practices.
Ensured compatibility with concurrent features introduced in React 18.
Verified that all tests pass and application behavior remains consistent.
Why this change is necessary:

Enzyme does not support React 18 and is no longer actively maintained.

@openedx-webhooks
Copy link

Thanks for the pull request, @psrigummadidala!

This repository is currently maintained by @openedx/2u-phoenix.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 6, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Aug 6, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Aug 6, 2025
@psrigummadidala psrigummadidala changed the title feat: Migrate test cases from enzyme to RTL test: migrated test cases from enzyme to rtl Aug 18, 2025
@ankit-sonata
Copy link

@psrigummadidala Build is getting failed, Make sure the build should pass

@psrigummadidala
Copy link
Author

psrigummadidala commented Aug 25, 2025 via email

@psrigummadidala psrigummadidala changed the title test: migrated test cases from enzyme to rtl feat: migrated test cases from enzyme to rtl Aug 26, 2025
@psrigummadidala psrigummadidala changed the title feat: migrated test cases from enzyme to rtl test: migrated test cases from enzyme to RTL Aug 26, 2025
@psrigummadidala psrigummadidala changed the title test: migrated test cases from enzyme to RTL test: migrate test cases from enzyme to RTL Aug 26, 2025
@ankit-sonata
Copy link

@psrigummadidala The build is failing due to commit lint fix them.

@psrigummadidala psrigummadidala force-pushed the Prod-4397 branch 3 times, most recently from 6ff1c74 to 0151db2 Compare August 30, 2025 03:58
@psrigummadidala psrigummadidala force-pushed the Prod-4397 branch 4 times, most recently from 22521af to 6bb6b8a Compare September 10, 2025 07:09
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 57.97101% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.49%. Comparing base (4e29750) to head (a920f66).

Files with missing lines Patch % Lines
src/index.jsx 0.00% 28 Missing ⚠️
src/users/data/api.js 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
+ Coverage   85.94%   90.49%   +4.54%     
==========================================
  Files         185      185              
  Lines        3879     3894      +15     
  Branches      959      966       +7     
==========================================
+ Hits         3334     3524     +190     
+ Misses        527      357     -170     
+ Partials       18       13       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ankit-sonata
Copy link

@psrigummadidala code coverage for this PR is currently around 58%, which falls short of our required threshold of 86%.
Please enhance the test coverage to align with the projects quality standards.

@psrigummadidala psrigummadidala requested review from skumargupta83 and removed request for DawoudSheraz September 23, 2025 06:29
@psrigummadidala
Copy link
Author

Hey @Faraz32123 could you please help review/merge this PR

@Faraz32123
Copy link

Hey @Faraz32123 could you please help review/merge this PR

Hi @psrigummadidala, can you close this PR and make a PR against edx/frontend-app-support-tools
fork repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

5 participants