-
Notifications
You must be signed in to change notification settings - Fork 27
test: migrate test cases from enzyme to RTL #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @psrigummadidala! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@psrigummadidala Build is getting failed, Make sure the build should pass |
Hi Ankith,
Thanks for the update. I’ll look into the build issue right away and ensure
it passes. I’ll keep you posted once it’s resolved .
Best regards
Padmasri.G
…On Thu, Aug 21, 2025 at 12:34 AM ankit-sonata ***@***.***> wrote:
*ankit-sonata* left a comment (openedx/frontend-app-support-tools#465)
<#465 (comment)>
@psrigummadidala <https://github.com/psrigummadidala> Build is getting
failed, Make sure the build should pass
—
Reply to this email directly, view it on GitHub
<#465 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BT7RJWSFUXQW2LUDSEWWL2T3OTBELAVCNFSM6AAAAACDHRTDM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMBXGY4DEMRRG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
*Padmasri Gummadidala*
*Senior digital engineer*
Employee of Sonata Software supporting 2U, LLC
Vamsiram Suvarnadurga Tech Park, Gachibowli, Hyderabad, Telangana 500032,
India
Disclaimer: This message was sent by a contractor and may contain
confidential or personal data. It does not create any binding obligation on
behalf of 2U unless expressly confirmed in a formal agreement. If you are
not the intended recipient, please notify the sender and delete this
message immediately.
|
@psrigummadidala The build is failing due to commit lint fix them. |
6ff1c74
to
0151db2
Compare
22521af
to
6bb6b8a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #465 +/- ##
==========================================
+ Coverage 85.94% 90.49% +4.54%
==========================================
Files 185 185
Lines 3879 3894 +15
Branches 959 966 +7
==========================================
+ Hits 3334 3524 +190
+ Misses 527 357 -170
+ Partials 18 13 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6bb6b8a
to
a920f66
Compare
@psrigummadidala code coverage for this PR is currently around 58%, which falls short of our required threshold of 86%. |
Hey @Faraz32123 could you please help review/merge this PR |
Hi @psrigummadidala, can you close this PR and make a PR against edx/frontend-app-support-tools |
https://2u-internal.atlassian.net/browse/PROD-4397
Description:
This PR includes the following changes:
Upgraded React and React DOM from version 17 to 18.
Removed Enzyme and related dependencies (enzyme, enzyme-adapter-react-16, etc.).
Rewritten all unit tests using React Testing Library to align with React 18 best practices.
Ensured compatibility with concurrent features introduced in React 18.
Verified that all tests pass and application behavior remains consistent.
Why this change is necessary:
Enzyme does not support React 18 and is no longer actively maintained.