- 
                Notifications
    You must be signed in to change notification settings 
- Fork 27
feat: added dropdowns for v2 #815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: zafzal/ENT7364
Are you sure you want to change the base?
Conversation
| Codecov ReportPatch coverage:  
 Additional details and impacted files@@                Coverage Diff                 @@
##           zafzal/ENT7364     #815      +/-   ##
==================================================
- Coverage           84.80%   84.38%   -0.43%     
==================================================
  Files                 328      329       +1     
  Lines                6682     6661      -21     
  Branches             1624     1614      -10     
==================================================
- Hits                 5667     5621      -46     
- Misses                983     1008      +25     
  Partials               32       32              
 ☔ View full report in Codecov by Sentry. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the screenshots of the new dropdowns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @jajjibhai008 There is no border here. It's showing due to the cursor being here while taking the screenshot. I have updated the image in PR. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolve the coverage issues. Other than that LGTM 👍
| This is just for the sake of design. It will go to frontend-enterprise. That's why tests are not added. | 

For all changes
Only if submitting a visual change