Skip to content

Conversation

Lunyachek
Copy link
Contributor

Description

This PR updates the logic that controls the visibility of the Order History link in the LMS user dropdown menu.

Previously, the link was shown whenever the user was not associated with an enterprise portal:

should_show_order_history = not enterprise_customer_portal

With this change, the link is only shown if:

  • The user is not associated with an enterprise portal, and
  • settings.ORDER_HISTORY_MICROFRONTEND_URL is configured.

This ensures that the Order History link only appears when the new Order History MFE is enabled and available, avoiding broken links.

@openedx-webhooks
Copy link

Thanks for the pull request, @Lunyachek!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 14, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Sep 14, 2025
@ihor-romaniuk ihor-romaniuk force-pushed the lunyachek/fix/order-history-link-visibility branch from 2dfa49f to 9826753 Compare September 15, 2025 09:40
@mphilbrick211 mphilbrick211 added the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Sep 16, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Sep 16, 2025
@Lunyachek Lunyachek force-pushed the lunyachek/fix/order-history-link-visibility branch from 9826753 to 25b0970 Compare September 29, 2025 20:17
@mphilbrick211 mphilbrick211 moved this from Ready for Review to Ready to Merge in Contributions Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs reviewer assigned PR needs to be (re-)assigned a new reviewer open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready to Merge

Development

Successfully merging this pull request may close these issues.

4 participants