[SDK] Misc cleanup in attribute_utils.h #3716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3716 +/- ##
==========================================
+ Coverage 89.95% 90.00% +0.06%
==========================================
Files 225 225
Lines 7103 7099 -4
==========================================
Hits 6389 6389
+ Misses 714 710 -4
🚀 New features to boost your workflow:
|
owent
approved these changes
Oct 26, 2025
Reneg973
force-pushed
the
CPP_CodeFlaw_Fixes
branch
from
2104d07 to
905ee82
Compare
marcalff
approved these changes
Oct 26, 2025
marcalff
changed the title
|
See clang-format, there is an extra blank line that needs to be removed. Will merge after that, congratulations on your first merged PR. |
- prevent superfluous copy in construction of OwnedAttributeValue with std::string or span - combined identical lambdas of both lamdas - use const-ref - removed unneeded (stateless) members
Reneg973
force-pushed
the
CPP_CodeFlaw_Fixes
branch
from
905ee82 to
3222db5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
none
Changes
Regarding the 2 constructors, IMO the pointer constructor is superfluous. Unfortunately it is being referenced already. So I'm not sure whether it's allowed to remove it.
Details:
const std::vector<T> copy(vals.begin(), vals.end());this const prevents from moving