Save zoom state when writing stimulus parameters #497
Conversation
|
When I scroll aggressively, sometimes, all the waveforms disappear and I cant find them. This both should not happen and there should be a 
|
|
its seems like there is some arbitrary max zoom setting that does not allow me to see pulse shapes in cerntain aspect ratios where the aspect ratio is defined as pulse width/stim sequence length: 
|
|
Scale bars X/Y starting points need to account for line width so they dont look hacked 
|
bparks13
force-pushed
the
issue-349
branch
2 times, most recently
from
551758b to
5810ddb
Compare
|
GIFs of behavior: Save Zoom State [Note: no change since the last update in behavior, but implementation has been updated]
Reset Zoom After removing the zoom-in boundary checking in 631c78f, it is possible for users to zoom in excessively and lose all reference in the axis. The Reset Zoom button can get them out of this state now.
|
- Clamp the maximum height of the scale bar to be 25% of the height of the Y-Axis
|
I just put 1 in all the boxes and applied to all channels. Says its valid and plots nothing: 
I realized this was because the zoom was not reset, even when going from no stimulus to a defined stimulus. It seems to me that in this case you probably want to invoke reset zoom. Another thing I noticed was that changing a value with the electrode selected does not make the change automatically, the user needs to press apply. I think maybe the apply button is not needed and that changes should be applied when they are made. EDIT: I took care of the automatic update stuff, but the initial zoom behavior still needs to be addressed, |
- Instead of requiring user to press Apply button, leaving the control or pressing enter causes and stimulus update.
|
@jonnew With the new changes, if the user has not selected a contact then they could be receive the same warning multiple times if they are setting stimulus parameters without selecting a contact: 
This warning fires whenever they leave the current UI element, so if they are tabbing through the controls and aren't changing parameters, the same warning pops up. Additionally, this commit also disrupts the tab order, with the new UI element now occurring after the buttons instead of before. I understand the intent behind these changes, and I think that we should probably get rid of the pop-up window so that users can freely modify parameters without selecting a contact. This way, they can get the benefit of immediate updates if they have a contact selected, or they can deselect all contacts and set the parameters they want before choosing a contact and pressing Apply. I will address these changes, and also fix the zoom state when first drawing a stimulus. |
- Reset zoom state when drawing a stimulus after none was presented; the update to save the zoom state inadvertently caused the pane to remain blank in this scenario - Remove dialog warning that no contacts are selected after the addition of automatic updates - Correct the tab order of UI elements
This PR now saves the zoom state when writing stimulus parameters, and reapplies the zoom state so that any changes can be immediately viewed without needing to zoom in again.
Example GIF
Example GIF: Timebase Changes
Note that this may conflict with #459, since that PR refactors this class to be more generalized. Care needs to be taken that whichever one gets merged first is brought back into the other one so that the behavior remains correctly fixed.
Fixes #349