Skip to content

Conversation

cjsha
Copy link
Member

@cjsha cjsha commented Sep 1, 2025

Also:

  • Add references to this tutorial throughout other articles
  • Add workflows for the LoadTester operators

Fix #225 Fix #25


Things I wanna flag for you to have in mind during your review of this initial commit:

  • Feels verbose, especially the beginning. There is a preamble which takes a minute to get through to get to the meat and bones of the tutorial where ReadSize is tuned to show the effect it has on latency and the hardware buffer data accumulation.
  • I wanna be technical and correct while being as clear and straightforward as possible. Some feedback to make sure I accomplish this would be great
  • There are a couple notes in the .md file in the form of <!-- --> comments which describe some aspects about the workflow that I wasn't sure how to explain

Also:
- Add references to this tutorial throughout other articles
- Add workflows for the LoadTester operators
@cjsha cjsha changed the title 1st draft tutorial for tuning ReadSize Tutorial for tuning ReadSize Sep 1, 2025
cjsha and others added 2 commits September 2, 2025 09:44
Copy link
Member

@jonnew jonnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. I made a bunch of edits that need a thorough review along with a couple comments.

in addition to some clarifying edits
@cjsha cjsha requested a review from jonnew September 8, 2025 13:53
- Populate the second table accordingly.
- Change the properties screenshot.
- Add additional explanation for the second table.
Copy link
Member

@ChucklesOnGitHub ChucklesOnGitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I placed my comments in a different branch, as per our conversation.
https://github.com/open-ephys/bonsai-onix1-docs/tree/issue-255-25-ch

@cjsha
Copy link
Member Author

cjsha commented Sep 15, 2025

Add admonition to readsize tutorial regarding this comment.

open-ephys/bonsai-onix1#498 (comment)

chuckles feedback for read-size tutorial + edits

---------

Co-authored-by: Ceci Herbert <ceci.herbert@hotmail.com>
Co-authored-by: Ceci Herbert <ceci@oeps.tech>
- how to measure latency using the devices that will be used during the actual experiment rather than loadtester
@cjsha cjsha merged commit 1922722 into main Sep 18, 2025
3 checks passed
@cjsha cjsha deleted the issue-225-25 branch September 18, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting ReadSize tutorial Example for Determining Optimal BlockReadSize
3 participants