-
Notifications
You must be signed in to change notification settings - Fork 7
emt idv iso generation json, build script, workflow and readme #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
- This will make the script independent Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
- taking care of review comments Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
- for providing tag - for providing image config json file Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
- also few enhancements in script Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
@@ -0,0 +1,52 @@ | |||
# This is a workflow that is triggered to build EMT desktop virtualization (IDV) ISO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add copyright
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taken care here: 5f41289
emt-dv-iso/README.md
Outdated
``` | ||
Command line arguments are optional. Below default values will be used : | ||
- Latest emt release tag : [3.0.20250718](https://github.com/open-edge-platform/edge-microvisor-toolkit/releases/tag/3.0.20250718) | ||
- [idv.json](https://github.com/open-edge-platform/edge-desktop-virtualization/blob/main/emt-dv-iso/idv.json) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hyperlink leads to "404 - page not found"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is futuristic link. Once the PR is merged, this link will be active :)
Just to avoid one more PR after this is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have updated it now. c615e90
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
- will enable branch protection on this. Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
* Update idv.json * Update build_idv_iso.sh * Update build_idv_iso.sh reverting the test changes
run: | | ||
wget https://raw.githubusercontent.com/open-edge-platform/edge-desktop-virtualization/refs/heads/emt-dv-iso/emt-dv-iso/build_idv_iso.sh | ||
chmod a+x build_idv_iso.sh | ||
if [[ -z "${{ inputs.myInput }}" ]]; then |
Check warning
Code scanning / zizmor
code injection via template expansion Warning
if [[ -z "${{ inputs.myInput }}" ]]; then | ||
./build_idv_iso.sh | ||
else | ||
./build_idv_iso.sh -t "${{ inputs.myInput }}" |
Check warning
Code scanning / zizmor
code injection via template expansion Warning
* readme changes Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com> * adding wifi related package - wpa_supplicant Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com> --------- Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
* Update idv-iso-builder.yaml update the default build tag * Update build_idv_iso.sh update the build tag * Update idv-iso-builder.yaml update the branch name * Update idv-iso-builder.yaml
No description provided.