Skip to content

Conversation

smitesh-sutaria
Copy link
Contributor

No description provided.

Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
- This will make the script independent

Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
@smitesh-sutaria smitesh-sutaria requested review from AishaSamaanKhan, Dhanya122 and a team July 24, 2025 07:21
- taking care of review comments

Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Dhanya122
Dhanya122 previously approved these changes Jul 24, 2025
Copy link
Contributor

@Dhanya122 Dhanya122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
@smitesh-sutaria smitesh-sutaria marked this pull request as ready for review July 24, 2025 21:13
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
- for providing tag
- for providing image config json file

Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
- also few enhancements in script

Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
@smitesh-sutaria smitesh-sutaria requested review from Dhanya122, vinayg-intel and a team July 25, 2025 20:29
@@ -0,0 +1,52 @@
# This is a workflow that is triggered to build EMT desktop virtualization (IDV) ISO

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add copyright

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken care here: 5f41289

```
Command line arguments are optional. Below default values will be used :
- Latest emt release tag : [3.0.20250718](https://github.com/open-edge-platform/edge-microvisor-toolkit/releases/tag/3.0.20250718)
- [idv.json](https://github.com/open-edge-platform/edge-desktop-virtualization/blob/main/emt-dv-iso/idv.json)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hyperlink leads to "404 - page not found"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is futuristic link. Once the PR is merged, this link will be active :)
Just to avoid one more PR after this is merged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have updated it now. c615e90

@smitesh-sutaria smitesh-sutaria changed the title emt idv iso generation json, build script and readme emt idv iso generation json, build script, workflow and readme Jul 26, 2025
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
@smitesh-sutaria smitesh-sutaria requested review from vinayg-intel and a team July 26, 2025 18:12
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
- will enable branch protection on this.

Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
* Update idv.json

* Update build_idv_iso.sh

* Update build_idv_iso.sh

reverting the test changes
run: |
wget https://raw.githubusercontent.com/open-edge-platform/edge-desktop-virtualization/refs/heads/emt-dv-iso/emt-dv-iso/build_idv_iso.sh
chmod a+x build_idv_iso.sh
if [[ -z "${{ inputs.myInput }}" ]]; then

Check warning

Code scanning / zizmor

code injection via template expansion Warning

code injection via template expansion
if [[ -z "${{ inputs.myInput }}" ]]; then
./build_idv_iso.sh
else
./build_idv_iso.sh -t "${{ inputs.myInput }}"

Check warning

Code scanning / zizmor

code injection via template expansion Warning

code injection via template expansion
* readme changes

Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>

* adding wifi related package

- wpa_supplicant

Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>

---------

Signed-off-by: Smitesh Sutaria <smitesh.sutaria@intel.com>
@smitesh-sutaria smitesh-sutaria added the do-not-merge PR tagged should not be merged. label Aug 5, 2025
* Update idv-iso-builder.yaml

update the default build tag

* Update build_idv_iso.sh

update the build tag

* Update idv-iso-builder.yaml

update the branch name

* Update idv-iso-builder.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge PR tagged should not be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants