Skip to content

draft starting point for addressing custom units with default product names issue #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

draft starting point for addressing custom units with default product names issue #1616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions PySDM/products/impl/product.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

class Product:
def __init__(self, *, unit: str, name: Optional[str] = None):
self.non_default_name = name is not None
self.name = name or camel_case_to_words(self.__class__.__name__)

self._unit = self._parse_unit(unit)
Expand Down Expand Up @@ -87,6 +88,12 @@ def __check_unit(self):
f" for product {type(self).__name__}"
)

if self._unit != default_unit and not self.non_default_name:
raise AssertionError(
f"custom non-SI unit specified for product {type(self).__name__}"
" requires a custom name (intention: include the custom unit in the name)"
)

@property
def unit(self):
return str(self._unit)
Expand Down
Loading