Skip to content

Conversation

dominikl
Copy link
Member

Exclude https://www.mail-archive.com/tiff@lists.osgeo.org/msg00421.html from linkcheck, as it often times out.

@dominikl dominikl requested a review from pwalczysko September 29, 2025 10:43
@pwalczysko
Copy link
Member

Copy link
Member

@pwalczysko pwalczysko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Atm does not work as expected, see above.

@pwalczysko
Copy link
Member

I think we could try to exclude https://www.mail-archive.com* (i.e. not slash-dot-star but just star). What do you think @melissalinkert please ?

@melissalinkert
Copy link
Member

I think we could try to exclude https://www.mail-archive.com* (i.e. not slash-dot-star but just star). What do you think @melissalinkert please ?

That approach makes sense to me.

@melissalinkert
Copy link
Member

If I run mvn test -DskipSphinxTests=false -Dome-model.uri=/bio-formats-build/ome-model/docs/sphinx/target/sphinx/html locally with this change, then the results in target/sphinx/linkcheck/output.json show that the link is correctly ignored:

$ grep mail-archive output.json 
{"filename": "about/whats-new.rst", "lineno": 230, "status": "ignored", "code": 0, "uri": "https://www.mail-archive.com/tiff@lists.osgeo.org/msg00421.html", "info": ""}

It's not clear to me why https://merge-ci.openmicroscopy.org/jenkins/job/BIOFORMATS-linkcheck/610/ and preceding builds continue to fail. If I remember correctly, we had similar issues with #430, so perhaps a similar fix on the CI side is needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants