fix(tools): set strict=true for all chat tools #2103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add strict=true to all function tool schemas to ensure consistent strictness across the chat tool catalog. When I use a third-party model to call tools, I get an error: `All function tools should have the same strictness.` So I think all tools should set strict to true, tested this is correct
|
May I ask what provider those errors come from? Also, if this is consistently happening across all tools, maybe we should emphasise this in the docs as well. |
This is our company's model, a third-party Kimi-K2 model, not an official model. |
|
I've never come across, nor have I heard of this being an issue before.. I can't accept this PR if we're not going to test this for every single adapter that supports function calling. |
olimorris
added
P4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add strict=true to all function tool schemas to ensure consistent strictness across the chat tool catalog.
When I use a third-party model to call tools, I get an error:
All function tools should have the same strictness.So I think all tools should set strict to true, tested this is correctScreenshots
Checklist
CodeCompanion.hasin the init.lua file for my new featuremake allto ensure docs are generated, tests pass and my formatting is applied