Release diffast v0.3.5.1 (part0)

[codinuum]

No description provided.

[jmid]

I spotted dune crashing on the Cygwin MinGW run of this PR and reported it here: ocaml/dune#12535

[jmid]

Besides crashing dune 😮 this is triggering a ton of vlt.0.2.5 failures:

#=== ERROR while compiling vlt.0.2.5 ==========================================#
# context              2.2.1 | linux/x86_64 | ocaml-base-compiler.5.3.0 | file:///home/opam/opam-repository
# path                 ~/.opam/5.3/.opam-switch/build/vlt.0.2.5
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p vlt -j 71 @install
# exit-code            1
# env-file             ~/.opam/log/vlt-6-c2abfc.env
# output-file          ~/.opam/log/vlt-6-c2abfc.out
### output ###
# File "ppx/dune", lines 2-11, characters 0-162:
#  2 | (rule
#  3 |  (deps (:< vlt_ppx.ml.cppo))
#  4 |  (targets vlt_ppx.ml)
#  5 |  (action
#  6 |   (with-stdout-to
#  7 |    %{targets}
#  8 |    (run %{bin:cppo} -V "PPXLIB:%{version:ppxlib}" %{<})
#  9 |   )
# 10 |  )
# 11 | )
# (cd _build/default/ppx && /home/opam/.opam/5.3/bin/cppo -V PPXLIB: vlt_ppx.ml.cppo) > _build/default/ppx/vlt_ppx.ml
# Error: Invalid version specification: "PPXLIB:"

It seems the failures are triggered when using ppxlib.0.37.0~5.4preview but not when using ppxlib.0.36.2 🤔

I can see you also released that one @codinuum in #27580 where it was all green even ✔️

As an experiment, could you try adding a commit where you add the following conflict to packages/vlt/vlt.0.2.5/opam?

conflicts: [ "ppxlib"  {= "0.37.0~5.4preview"}

[jmid]

Nice: from 394 jobs failed to 58 jobs failed! 😃

#28671 should fix the diffast-git-cli.0.1.1 and diffast-git-cli.0.2 errors.

opam-2.0 is failing with

• a timeout
• understanding the flag avoid-version in ppxlib:

  [ERROR] In the opam file for ppxlib.0.36.2:
          - At /home/opam/.opam/repo/default/packages/ppxlib/ppxlib.0.36.2/opam:54:0:
            Unknown package flags avoid-version ignored
        'flags' has been ignored.
  

(I guess we can ignore these)

A couple of build failures of diffast-langs-cpp-parsing.0.3.5.1 remain:

• on ocaml-4.14-fp (a stack overflow)
• on the ARM32 architecture with both 4.14 and 5.3 - is this package supposed to build and work there?
• on the s390x architecture with 4.14 with a segfault (while it seems to pass on s390x with 5.3). Is that ocamlopt.opt segfaulting? 😮 If so, it could be worth carving out reproduction steps and reporting it to ocaml/ocaml:

  #=== ERROR while compiling diffast-langs-cpp-parsing.0.3.5.1 ==================#
  # context              2.4.1 | linux/s390x | ocaml-base-compiler.4.14.2 | pinned(https://github.com/codinuum/diffast/archive/v0.3.5.1.tar.gz)
  # path                 ~/.opam/4.14/.opam-switch/build/diffast-langs-cpp-parsing.0.3.5.1
  # command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p diffast-langs-cpp-parsing -j 3 --promote-install-files=false @install
  # exit-code            1
  # env-file             ~/.opam/log/diffast-langs-cpp-parsing-6-6112f7.env
  # output-file          ~/.opam/log/diffast-langs-cpp-parsing-6-6112f7.out
  ### output ###
  # (cd _build/default/src/api/dev && /usr/bin/git describe --always --dirty) > _build/default/src/api/dev/v
  # fatal: not a git repository (or any parent up to mount point /)
  # Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
  # File "src/langs-cpp-parsing/parsing/.cpp_parsing.objs/native/_unknown_", line 1, characters 0-0:
  # (cd _build/default && /home/opam/.opam/4.14/bin/ocamlopt.opt -w -40 -w -67 -O3 -I src/langs-cpp-parsing/parsing/.cpp_parsing.objs/byte -I src/langs-cpp-parsing/parsing/.cpp_parsing.objs/native -I /home/opam/.opam/4.14/lib/base64/rfc2045 -I /home/opam/.opam/4.14/lib/bytesrw -I /home/opam/.opam/4.14/lib/bytesrw/zlib -I /home/opam/.opam/4.14/lib/camlp-streams -I /home/opam/.opam/4.14/lib/cryptokit -I /home/opam/.opam/4.14/lib/diffast-langs-common -I /home/opam/.opam/4.14/lib/diffast-misc -I /home/opam/.opam/4.14/lib/gen -I /home/opam/.opam/4.14/lib/markup -I /home/opam/.opam/4.14/lib/menhirLib -I /home/opam/.opam/4.14/lib/sedlex -I /home/opam/.opam/4.14/lib/seq -I /home/opam/.opam/4.14/lib/uutf -I /home/opam/.opam/4.14/lib/vlt -I /home/opam/.opam/4.14/lib/zarith -intf-suffix .ml -no-alias-deps -open Cpp_parsing -o src/langs-cpp-parsing/parsing/.cpp_parsing.objs/native/cpp_parsing__Parser.cmx -c -impl src/langs-cpp-parsing/parsing/parser.pp.ml)
  # Command got signal SEGV.
  

[jmid]

This is now down to CI failures on opam-2.0 and on Windows (incl. the dune crash).

Currently this includes 156c1bf to avoid vlt.2.5.0 failing all over the place. I'm in favor of including the commit, but if we do, we should consider rephrasing the commit message to something more saying, like, "Mark vlt.0.2.5 as conflicting with ppxlib.0.37.0~5.4preview".

Finally: would you consider adding x-maintenance-intent entries for these packages?
https://github.com/ocaml/opam-repository/blob/master/governance/policies/archiving.md