Skip to content

Conversation

dinosaure
Copy link
Contributor

SPAKE+EE implementation in OCaml

CHANGES:

CHANGES:

- Update to `mirage-crypto.1.0.0` (@dinosaure, dinosaure/spoke#10)
Co-authored-by: Jan Midtgaard <mail@janmidtgaard.dk>
@jmid
Copy link
Member

jmid commented Oct 3, 2025

This compiles and installs on arm32 but then triggers a Bus error during a test run:

#=== ERROR while compiling spoke.0.0.4 ========================================#
# context              2.4.1 | linux/arm32 | ocaml-base-compiler.4.14.2 | pinned(https://github.com/dinosaure/spoke/releases/download/v0.0.4/spoke-0.0.4.tbz)
# path                 ~/.opam/4.14/.opam-switch/build/spoke.0.0.4
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune runtest -p spoke -j 79
# exit-code            1
# env-file             ~/.opam/log/spoke-7-a6fd88.env
# output-file          ~/.opam/log/spoke-7-a6fd88.out
### output ###
# File "test/simulate.t", line 1, characters 0-0:
# /usr/bin/git --no-pager diff --no-index --color=always -u _build/default/test/simulate.t _build/default/test/simulate.t.corrected
# diff --git a/_build/default/test/simulate.t b/_build/default/test/simulate.t.corrected
# index 4aed4d1..c01ff0a 100644
# --- a/_build/default/test/simulate.t
# +++ b/_build/default/test/simulate.t.corrected
# @@ -1,3 +1,5 @@
#  Simulate communication with Spoke
#    $ echo "Hello World!" > hello
#    $ ../bin/simulate.exe hello 127.0.0.1:4242 hello-world
# +  Bus error
# +  [135]

Should we guard the test suite with arch != "arm32" or disable the package on ARM32 entirely, to be on the safe side? 🤔

@dinosaure
Copy link
Contributor Author

I decided to disallow tests for arm32 and x86_32 👍.

Copy link
Member

@jmid jmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

The FreeBSD failure is due to struggling workers and can be ignored as the previous run passed.

I almost forgot my usual question: 🙂
Would you consider adding an x-maintenance-intent entry?

@mseri mseri merged commit fa2f2e5 into ocaml:master Oct 10, 2025
3 of 4 checks passed
@mseri
Copy link
Member

mseri commented Oct 10, 2025

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants