solves Line2D attribute error with matplotlib 3.7.0
#571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the error on most recent matplotlib version is the following: ```bash AttributeError: 'Line2D' object has no attribute '_us_dashSeq' ```
|
@nschloe, ping. Is tikzplotlib still maintained? I'd like to know whether there's a point waiting for new matplotlib support or if we should remove tikzplotlib from Gentoo. |
|
@mgorny I haven't had much time for tpl indeed. Not exactly sure when I'll be able to again. If it's a blocker for you, best remove it, and add it again when I get back to it. |
st--
reviewed
May 6, 2023
Comment on lines
+472
to
+473
| dashOffset = line._dash_pattern[0] | ||
| dashSeq = line._dash_pattern[1] |
There was a problem hiding this comment.
As in https://github.com/nschloe/tikzplotlib/pull/558/files, it would be better to keep this backwards-compatible:
Suggested change
| dashOffset = line._dash_pattern[0] | |
| dashSeq = line._dash_pattern[1] | |
| try: | |
| dashOffset, dashSeq = line._dash_pattern[:2] | |
| except AttributeError: | |
| # backwards-compatibility with matplotlib < 3.7.0 | |
| dashOffset = line._us_dashOffset | |
| dashSeq = line._us_dashSeq |
Repository owner
deleted a comment from
st--
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the error on most recent matplotlib version is the following: