Skip to content

Conversation

jwallwork23
Copy link
Contributor

@jwallwork23 jwallwork23 commented Aug 12, 2025

XIOS: account for DGField and VertexField

Fixes #831
Merges into #872
Towards #850


Change Description

This PR overhauls the XIOS implementation to account for DGField and VertexField, as well as HField, which was already covered. This required setting up separate XIOS grids for each field type, themselves formed of different combinations of axes and domains.

  • HGrid is the simplest case, with a x-y domain (HDomain).
  • VertexGrid has its own xvertex-yvertex domain (VertexDomain) and also an axis with ncoords components (VertexAxis).
  • DGGrid uses HDomain, along with an axis with dg_comp components (DGAxis).

The PR also fixes misc typos, inlines setFieldOperation with 'instant' mode (which is always assumed), and drops getFieldOperation as no longer needed.

Checklist


Test Description

Various XIOS tests needed reworking to account for this change.

@jwallwork23 jwallwork23 self-assigned this Aug 12, 2025
@jwallwork23 jwallwork23 added enhancement New feature or request ICCS Tasks or reviews for the ICCS team labels Aug 12, 2025
Base automatically changed from issue768_xios-getmodelstate-nogroup to develop August 20, 2025 06:39
@jwallwork23 jwallwork23 force-pushed the issue831_xios-other-fields branch from b1d7cfa to af65786 Compare August 20, 2025 16:11
@jwallwork23 jwallwork23 marked this pull request as ready for review August 29, 2025 08:36
@jwallwork23
Copy link
Contributor Author

Added and used ModelArray::Base in e583946. This is currently hooked up in discontinuousgalerkin but not finitevolume. What base types would make sense in the latter? Facet or just Vertex?

Copy link
Collaborator

@timspainNERSC timspainNERSC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That all looks reasonable.

@jwallwork23
Copy link
Contributor Author

I'll hold off merging this until #744 is merged to avoid slowing it down.

@jwallwork23
Copy link
Contributor Author

Created branch issue831_xios-other-fields_halo-exchange in preparation for merging after #744. [skip ci]

@jwallwork23 jwallwork23 merged commit 9dccbe0 into develop Oct 2, 2025
5 checks passed
@jwallwork23 jwallwork23 deleted the issue831_xios-other-fields branch October 2, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ICCS Tasks or reviews for the ICCS team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XIOS: Handle writing of DGField and VertexField
2 participants