-
Notifications
You must be signed in to change notification settings - Fork 19
XIOS: account for DGField and VertexField #910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b1d7cfa
to
af65786
Compare
Added and used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That all looks reasonable.
I'll hold off merging this until #744 is merged to avoid slowing it down. |
Created branch |
XIOS: account for DGField and VertexField
Fixes #831
Merges into #872Towards #850
Change Description
This PR overhauls the XIOS implementation to account for
DGField
andVertexField
, as well asHField
, which was already covered. This required setting up separate XIOS grids for each field type, themselves formed of different combinations of axes and domains.HGrid
is the simplest case, with ax
-y
domain (HDomain
).VertexGrid
has its ownxvertex
-yvertex
domain (VertexDomain
) and also an axis withncoords
components (VertexAxis
).DGGrid
usesHDomain
, along with an axis withdg_comp
components (DGAxis
).The PR also fixes misc typos, inlines
setFieldOperation
with 'instant' mode (which is always assumed), and dropsgetFieldOperation
as no longer needed.Checklist
DGField
- see debug_other_fields_write.mdb.ModelArray
type - see debug_other_fields_read.mdb.VertexField
andDGField
(possibly related to above).Test Description
Various XIOS tests needed reworking to account for this change.