Skip to content

Conversation

einola
Copy link
Member

@einola einola commented Jul 22, 2025

Correctly skip land points in the stress update

Related to #883

Task List

  • Defined the tests that specify a complete and functioning change (It may help to create a design specification & test specification)
  • Implemented the source code change that satisfies the tests
  • Documented the feature by providing worked example
  • Updated the README or other documentation
  • Completed the pre-Request checklist below

Change Description

The previous version skipped ocean points and not land points. So I added a not (!) to the commit in PR #884.


Test Description

The instabilities in #883 are back, but the polynya test case (#797) now runs correctly again.


Documentation Impact

None


Other Details

None


Pre-Request Checklist

  • The requirements of this pull request are fully captured in an issue or design specification and are linked and summarised in the description of this PR
  • No new warnings are generated
  • The documentation has been updated (or an issue has been created to track the corresponding change)
  • Methods and Tests are commented such that they can be understood without having to obtain additional context
  • This PR/Issue is labelled as a bug/feature/enhancement/breaking change
  • File dates have been updated to reflect modification date
  • This change conforms to the conventions described in the README

The previous version skipped _ocean_ points and not land points. So I
added a not (!) to the commit in PR #884.
@einola einola requested a review from winzerle July 22, 2025 08:33
@einola einola mentioned this pull request Jul 22, 2025
12 tasks
@einola einola merged commit 23a8809 into develop Jul 23, 2025
12 checks passed
@einola einola deleted the issue883_mask_stress_update_fixed branch July 23, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants