Display the current configuration with the occ "status" command if "-v"

[rotdrop]

This PR displays the configuration of the gateways providers (phone numbers etc.) if the "-v" is passed to the occ invocation.

[vitormattos]

Already have a similar method called getSettings. Isn't this the same?

[rotdrop]

No, I thought it was but that "getSettings()" only returns the name and and instructions, see here:

twofactor_gateway/lib/Provider/Gateway/AGateway.php

Line 47 in 12a4780

public function getSettings(): array {

[vitormattos]

I'm thinking about replace the constant SCHEMA that is returned by settings by specific methods to return the values as the constant SCHEMA property provide. Maybe making this will be more clear to developers about what need to override. The schema is a bit fragile considering that haven't a contract that says what's necessary. I also thought about get back with a config class to each provider but this approach also will get back with a lot of files to implement a provider. That do you think about?

[rotdrop]

Indeed the public const SCHEMA = [ ... ] is rather "magic" or obscured. Having documented interface methods is preferable over the current state. So we are talking here about something like (?)

public function getName():string;
public function getInstructions():string;
public function getConfigurationKeys: array;
// and what else is needed

[rotdrop]

I can also convert this PR to a draft. Shall I? I'd like to see a status command which also displays the current configuration, but there is no hurry. Clearly, if you replace the SCHEMA property by something cleaner then this PR needs to be rewritten anyway.

[vitormattos]

replace the SCHEMA property by something cleaner

I wish to do this but I think that don't will affect this PR. Let's think more about.

[vitormattos]

Starting to check this.

[vitormattos]

Could you check again your PR after the last changes at main branch? I replaced the SCHEMA by a setting class.

[vitormattos]

I also implemented some tests covering the status command.

[rotdrop]

Ok, seems to work again. I should probably augment the test to cover also the output with the "-v / --verbose" flag in action.

I have also added a new method to the TConfigurable trait

private static function keyFromFieldName(string $id, string $fieldName):string {
                return $id . '_' . $fieldName;
}

in order to have just one place where the config keys are formed. I also saw that the handling of the provider id is slightly different in AGateway::isConfigured() and in the TConfigurable trait (the latter always ever only uses configuration->id, where AGateway looks at self::getProviderId().