fix self-mention in comments

[rikled]

• Resolves: User should able to mention themself #4184
• Target version: main

Summary

This workaround fixes the self-mention issue described in #4184 until nextcloud/server#48180 is implemented. The current user is now allowed to mention himself in the comments.

[juliusknorr]

Thanks a lot, I've restarted cypress as it seemed like an unrelated failure. I'll have a closer look later today

[juliusknorr]

Looks good, there is just a small comment regarding display names and a typo left from my perspective.

[rikled]

Thank you very much for the comments. Right, checking for the display name makes much more sense, I’ve added that. I also had a quick look at the server-side implementation, and it seems that UID checks are exact match checks there (which might explain why exact match actually works if uid===displayname). So to be consistent, maybe it makes sense to change the UID check to an exact match check against the input text?

Also, please let me know if I should add some unit tests (or even Cypress?). I couldn’t find a unit test setup in the project, so I skipped it this weekend due to time constraints (and some frustration with my currently very slow development setup).

[juliusknorr]

Sorry for the delayed response and thanks for checking this further in depth. I think the current approach implemented is good for this. I think not limiting uid check is more suitable, also comparing how for example Talk does the matches against the uid. Though I see it is not consistent with the autocomplete endpoint.

So far we only have cypress tests for the frontend code parts in this repo, however I fear those would be to much dependent on the implementation within Collabora Online, so hesitant adding them. It might be nice to add vitest to this repo and have some actual unit tests for parts like this where the full integration would be overkill, but seems to exceed the scope of this PR.

[juliusknorr]

Just one minor bit that I just noticed when giving this another test run, we probably should check case-insensitive?

[rikled]

I updated the check to be case-insensitive. The failing tests appear to be unrelated again, but I’ll take a closer look to confirm.

[juliusknorr]

Yes, those tests seem to also fail on main, so agree that they are unrelated https://github.com/nextcloud/richdocuments/actions/runs/18894277933

[juliusknorr]

Mind to squash your commits into one and rebase them to current main? Then it is good to go from my side 🚀

[juliusknorr]

With #5130 the tests should also pass again after the rebase

[rikled]

I’ve squashed all commits into one and rebased onto the latest main. All tests are passing again. Thanks for your constructive feedback!

[juliusknorr]

Thanks a lot 🤝