-
Notifications
You must be signed in to change notification settings - Fork 135
Update outdated LOOL references to COOL naming conventions #5108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
11ad2a8 to
d8a445d
Compare
- Update X-LOOL-WOPI-Timestamp header to X-COOL-WOPI-Timestamp with backward compatibility fallback - Update LOOLStatusCode to COOLStatusCode in JSON response - Update LOOL_STATUS_DOC_CHANGED constant to COOL_STATUS_DOC_CHANGED - Update test files to use new X-COOL-WOPI-Timestamp header - Maintain backward compatibility for legacy LOOL header Co-authored-by: juliusknorr <3404133+juliusknorr@users.noreply.github.com> Signed-off-by: Julius Knorr <jus@bitgrid.net>
d8a445d to
fc8af0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and document change detection still works. Also could not find other occurrences.
Description
This PR updates outdated references from LOOL (LibreOffice Online) to COOL (Collabora Online) following the naming convention change that occurred in November 2021.
Changes
Main Controller (
lib/Controller/WopiController.php)LOOL_STATUS_DOC_CHANGEDtoCOOL_STATUS_DOC_CHANGEDX-LOOL-WOPI-TimestamptoX-COOL-WOPI-TimestampX-LOOL-WOPI-TimestampheaderLOOLStatusCodetoCOOLStatusCodeTest File (
tests/features/bootstrap/WopiContext.php)X-LOOL-WOPI-TimestamptoX-COOL-WOPI-TimestampBackward Compatibility
The implementation maintains full backward compatibility by checking for the new
X-COOL-WOPI-Timestampheader first, and falling back to the legacyX-LOOL-WOPI-Timestampheader if not present. This ensures compatibility with both current and older Collabora Online installations.Related Issue
Fixes the outdated references mentioned in
richdocuments/lib/Controller/WopiController.php
Line 591 in 4e981ee
The naming change dates back to November 2021 when LibreOffice Online was rebranded to Collabora Online.
Original prompt
Fixes #5107
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.