Revisions to documentation #113
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 9, 2025 20:20
Both Win64 ABI and System V ABI clearly state that 16-byte stack alignment is required _before_ the call, not after. Added some additional details about the Win64 ABI, including a mention of "shadow space", which is one of the less intuitive aspects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I read through your documentation, and found some issues.
Lots of them were minor misspellings or grammatical issues, but there were some parts that I found deeply unclear in their meaning, and even parts that were just wrong (specifically the claim that the popular 64-bit system ABIs expect 16-byte stack alignment after the call, rather than before - AFAICT, this is exactly the opposite of what the specs say).
I have done my best to fix these issues, and have tried to split it into commits that might make it easier to review.
Thanks for the project, hope this helps!