-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Clean | Remove timm
dependency
#3637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. I think you might also need to update the pixi files as well?
@akristoffersen Thank for your the review! There is no |
ah sorry, I meant |
+1 here. Trying to use this with the huggingface transformers package and that uses a later version of timm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also looks good to me! Didn't realize timm is never used inside the repo, oops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry I misunderstood, Alex is right that pixi.lock needs to be regenerated.
Hello! Thank you for all the work here. Are there any updates on merging this? I am also encountering the same problem |
I searched the codebase and found that timm is actually not used. It seems this dependency was introduced in the following PR: #2284. However, I couldn’t find any place where timm is actually referenced 🤔
One reason I’d like to remove this dependency is that I need to install another package that also requires timm, but with a much higher version, which leads to a version conflict.