Implement GetServerInfo Handler with Routing Validation Fix and Full Testkit Integration #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Testkit - Enables retrieval of server information via the GetServerInfo request
…PHP Client and Testkit backend. This includes full request/response handling, driver integration, and a critical fix for routing table validation.
…PHP Client and Testkit backend. This includes full request/response handling, driver integration, and a critical fix for routing table validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @transistive 👋
I’ve prepared a detailed overview of all the architectural and functional changes included in this PR.
GetServerInfo End-to-End Implementation
Implemented complete GetServerInfo flow across the Neo4j PHP Client and Testkit backend.
Added getServerInfo() method in BoltDriver, Neo4jDriver, and DriverInterface.
Integrated full driver → connection → backend response chain.
Extracted server metadata from live connections for accurate reporting.
Provides consistent driver information for Testkit compliance.
Routing Table Validation & Bug Fix
Fixed critical issue where missing readers in the routing table caused connection failures.
Added routing table validation and fallback handling for clustered environments.
Ensures Neo4jDriver refreshes routing tables before establishing new connections.
Returns proper DriverError when no readers are available.
Aligned behavior with Neo4j’s routing protocol specification.
Connection & Pool Enhancements
Enhanced BoltConnection with improved error handling and metadata tracking.
Updated Neo4jConnectionPool to refresh and validate routing information before acquiring connections.
Improved connection reuse and cleanup across sessions.
Ensures stable connection lifecycle management and consistent server state retrieval.
Session Management Improvements
Session::close() now discards unconsumed results for proper cleanup.
Improved session consistency during concurrent or retried operations.
Ensures stable and predictable session behavior across driver invocations.