Skip to content

Conversation

@hadess
Copy link

@hadess hadess commented Feb 7, 2022

This works, but the speed is pretty atrocious. I don't know what calls it's doing in the background, but it seems to have problems redrawing fast enough to keep the UI responsive.

@neatdecisions
Copy link
Owner

Thank you!
Indeed, to have an acceptable UX here we'd need a proper asynchronous processing when switching location.
It's in the pipe, I'll wait with merging this PR until it's done.

@hadess
Copy link
Author

hadess commented Apr 19, 2022

The first 2 commits could be merged straight away though.

Don't rely on backends providing more information than we requested. If
we don't ask for the file type, some gvfs backend won't provide it.
@hadess hadess force-pushed the wip/hadess/remote-support branch from 608f6d7 to ca47c21 Compare December 11, 2022 19:07
@hadess
Copy link
Author

hadess commented Dec 11, 2022

I've rebased the code, still has the same problems, the first 2 commits could still be merged ;)

One thing I've also noticed is that "Move to Trash" won't work on some remote filesystems, and that the code should check for G_FILE_ATTRIBUTE_ACCESS_CAN_TRASH being true before enabling that feature (and probably also G_FILE_ATTRIBUTE_ACCESS_CAN_DELETE if it doesn't already).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants