-
Couldn't load subscription status.
- Fork 3k
added main window transparency on start #30770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added main window transparency on start #30770
Conversation
7298411 to
f021ae0
Compare
6cba575 to
26ff40d
Compare
|
Tested #29630 on Win10, Mac13.7.8, LinuxUbuntu24.04.3 LTS - FIXED |
| // ==================================================== | ||
| //! Needs to be set because we use transparent windows for PopupView. | ||
| //! Needs to be called before any QQuickWindows are shown. | ||
| QQuickWindow::setDefaultAlphaBuffer(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's better to leave this as it is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, dialogs and popups set this setting every time before opening, so the "global" setting is just confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it's supported at all to change this multiple times at runtime. The documentation says:
In any application which expects to create translucent windows, it's necessary to set this to true before creating the first QQuickWindow. The default value is false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Experience shows that this setting should be set before creating a window (not just any window, but the one it will apply to). This is already how it works for us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't seem to turn off transparency... I decided to just return it to how it was.
src/app/CMakeLists.txt
Outdated
| configure_file(${PROJECT_SOURCE_DIR}/buildscripts/packaging/Windows/PortableApps/appinfo.ini.in ${CMAKE_INSTALL_PREFIX}/../../App/AppInfo/appinfo.ini @ONLY) | ||
| endif (WIN_PORTABLE) | ||
|
|
||
| if (MUE_RUN_WINDEPLOYQT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: should be indented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
120c24c to
9a648e5
Compare
Resolves: #29630