-
Notifications
You must be signed in to change notification settings - Fork 84
Development #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iuliacimpeanu
wants to merge
146
commits into
main
Choose a base branch
from
development
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Development #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…download links and remove emoji icons for success and failure messages.
…s to be conditional based on environment variables. Update E2E test workflows to comment out Slack notifications and dependencies for cleaner execution.
…g timeout values and simplifying error handling. Remove unnecessary debug logging in global setup and streamline file read/write operations.
…option to prevent overwriting existing files. Improve logging for missing environment variables and successful file writes.
…enhance reliability. Introduce exponential backoff for retries and increase timeout duration to ensure successful loading.
…nt and remove unnecessary timeout. Adjust comments for better understanding of retry mechanism.
…lity. Set default navigation timeout to 10 seconds and adjust retry logic for better handling of navigation failures.
…Added explicit wait for close icon visibility before canceling the transaction. Updated navigation timeout in connect wallet tests for consistency and better error handling.
…nsaction test for now
…ased test timeout from 60 seconds to 90 seconds and locator timeout from 45 seconds to 60 seconds.
…s. Removed unnecessary debug code and improved the close icon click logic for better reliability.
…implifying the visibility check. Updated selector for the transactions ping-pong table for consistency.
…ts for transaction visibility. Updated selector for transactions table to enhance consistency and streamline the test logic.
…ss and failure in both merge and night test configurations.
…e-file-upload Add additional wait times to connect web wallet after keystore file upload
* Replace moment.js with luxon for date handling in Footer and PingPongComponent. Update package.json and pnpm-lock.yaml to reflect the dependency change. * Update luxon and @types/luxon versions in package.json and pnpm-lock.yaml to specific versions for consistency. * Fixed prettier and eslint sort imports/exports (#411) * Refactor various components and styles for improved consistency and readability. Removed unnecessary whitespace and comments, updated styles for better clarity, and made minor adjustments to imports across multiple files. * Refactor BatchTransactions and HomeHero styles for improved readability and consistency. Removed unnecessary whitespace and comments, and organized style definitions for clarity.
…c and improve error handling. Renamed clickElement to attemptClickElement, updated parameter structure, and enhanced error messages for better clarity during failures.
…ificationPage for element selection, improving clarity and consistency in handling page interactions.
… waitFor call to ensure the element is visible before clicking, improving interaction reliability and error handling.
…otification page is closed, improving robustness during interactions and error handling.
…d waitUntilStable. Added checks for page closure and enhanced logging for better visibility during interactions.
…ic and enhance error handling. Added a mechanism to ensure the debug directory exists, implemented a more robust approach for handling page closures, and improved logging for better visibility during retries and interactions.
… parameters, improving flexibility in page handling. Updated test cases to reflect changes in method signature, enhancing clarity and maintainability.
…ding and reduce CLICK_TIMEOUT in handleMetaMaskSnapApproval for improved interaction speed. Added special handling for MultiversX checkbox to enhance debugging.
…resh logic in handleMetaMaskSnapApproval to streamline the approval process and improve code clarity.
…le fully parallel test execution. Enhance debugging in handleMetaMaskSnapApproval by adding a wait before approving specific actions.
…ust timeouts in handleMetaMaskSnapApproval for improved interaction speed. Enhance debugging logs to track page states before and after actions.
…ask.spec.ts for consistency and improved readability.
…ess and failure notifications for both merge and night tests.
…n branch, removing development branch support.
…nnect-test Rm/update/e2e add metamask connect test
…n for improved reliability
…-loading-method e2e replace deprecated page loading method with a new utility function for improved reliability
| '\\.(css|sass|scss)$': 'identity-obj-proxy' | ||
| '\\.(css|sass|scss)$': 'identity-obj-proxy', | ||
| '^@multiversx/sdk-dapp-ui$': | ||
| '<rootDir>/src/__mocks__/@multiversx/sdk-dapp-ui.ts', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why needed?
| @@ -0,0 +1,21 @@ | |||
| // Mock for @multiversx/sdk-dapp-ui package | |||
| // This prevents Jest from trying to load web components that aren't compatible with jsdom | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this must be fixed
razvantomegea
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.