Linter issues

[sstanculeanu]

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

• was the PR targeted to the correct branch?
• if this is a larger feature that probably needs more than one PR, is there a feat branch created?
• if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

[github-actions]

❌ Integration Tests completed with failures or errors.

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

• mx-chain-go Commit Hash: d052697a1c89327bc2b2f8b72f7a20194c7130d3
• Current Branch: lint-issues
• mx-chain-go Target Branch: rc/supernova
• mx-chain-simulator-go Target Branch: rc/supernova
• mx-chain-testing-suite Target Branch: rc/supernova
• mx-chain-simulator-go Commit Hash: 41597fe08749e31c2513f9ee4e64526bedbfd767

🚀 Environment Variables:

• TIMESTAMP: 2025_OCTOBER_03__09_37_20
• PYTEST_EXIT_CODE: 1

[codecov]

Codecov Report

❌ Patch coverage is 71.03175% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.25%. Comparing base (164c3fd) to head (974bd33).
⚠️ Report is 460 commits behind head on rc/supernova.

Files with missing lines	Patch %	Lines
factory/processing/processComponentsHandler.go	55.84%	0 Missing and 34 partials ⚠️
factory/crypto/cryptoComponentsHandler.go	56.25%	0 Missing and 14 partials ⚠️
factory/core/coreComponentsHandler.go	80.95%	8 Missing ⚠️
...actory/bootstrap/testBootstrapComponentsHandler.go	0.00%	5 Missing ⚠️
cmd/termui/provider/logProvider.go	0.00%	3 Missing ⚠️
factory/bootstrap/bootstrapComponentsHandler.go	50.00%	2 Missing ⚠️
cmd/node/main.go	0.00%	1 Missing ⚠️
consensus/spos/bls/v2/subroundEndRound.go	0.00%	0 Missing and 1 partial ⚠️
factory/state/stateComponentsHandler.go	90.00%	1 Missing ⚠️
health/clock.go	50.00%	1 Missing ⚠️
... and 3 more

Additional details and impacted files

@@              Coverage Diff              @@
##           rc/supernova    #7306   +/-   ##
=============================================
  Coverage         75.25%   75.25%           
=============================================
  Files               838      838           
  Lines            137369   137355   -14     
=============================================
- Hits             103373   103363   -10     
+ Misses            28193    28190    -3     
+ Partials           5803     5802    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sstanculeanu]

Codecov Report

❌ Patch coverage is 71.03175% with 73 lines in your changes missing coverage. Please review. ✅ Project coverage is 75.25%. Comparing base (bfe1dd0) to head (880a599).

Files with missing lines Patch % Lines
factory/processing/processComponentsHandler.go 55.84% 0 Missing and 34 partials ⚠️
factory/crypto/cryptoComponentsHandler.go 56.25% 0 Missing and 14 partials ⚠️
factory/core/coreComponentsHandler.go 80.95% 8 Missing ⚠️
...actory/bootstrap/testBootstrapComponentsHandler.go 0.00% 5 Missing ⚠️
cmd/termui/provider/logProvider.go 0.00% 3 Missing ⚠️
factory/bootstrap/bootstrapComponentsHandler.go 50.00% 2 Missing ⚠️
cmd/node/main.go 0.00% 1 Missing ⚠️
consensus/spos/bls/v2/subroundEndRound.go 0.00% 0 Missing and 1 partial ⚠️
factory/state/stateComponentsHandler.go 90.00% 1 Missing ⚠️
health/clock.go 50.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files

@@               Coverage Diff                @@
##           rc/supernova    #7306      +/-   ##
================================================
- Coverage         75.25%   75.25%   -0.01%     
================================================
  Files               838      838              
  Lines            137341   137327      -14     
================================================
- Hits             103358   103341      -17     
- Misses            28183    28185       +2     
- Partials           5800     5801       +1     

☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

No new lines added, should be ok on rc branch

[github-actions]

❌ Integration Tests completed with failures or errors.

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

• mx-chain-go Commit Hash: 880a5998447fb88099890be64399520f87f6d417
• Current Branch: lint-issues
• mx-chain-go Target Branch: rc/supernova
• mx-chain-simulator-go Target Branch: rc/supernova
• mx-chain-testing-suite Target Branch: rc/supernova
• mx-chain-simulator-go Commit Hash: 41597fe08749e31c2513f9ee4e64526bedbfd767

🚀 Environment Variables:

• TIMESTAMP: 2025_OCTOBER_03__10_19_36
• PYTEST_EXIT_CODE: 1

[Copilot]

Pull Request Overview

This pull request addresses linter issues throughout the codebase by cleaning up comment formatting and standardizing variable naming patterns.

• Standardizes comment formatting by adding spaces after // markers
• Renames variables from expectedErr to errExpected for consistency
• Simplifies conditional logic and code structure where possible

Reviewed Changes

Copilot reviewed 218 out of 218 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
vm/systemSmartContracts/validator_test.go	Updated comment formatting to add spaces after // markers
vm/systemSmartContracts/esdt.go	Simplified boolean assignment by using direct comparison
update/factory/dataTrieFactory.go	Fixed import usage to use aliased import name
txcache/ files	Renamed error variables from expectedErr to errExpected for consistency
process/ files	Standardized error variable names and improved comment formatting
trie/ files	Updated error variable naming and simplified conditional logic
node/ files	Consistent error variable naming and comment formatting improvements
outport/ files	Updated error variable names and fixed property access

Comments suppressed due to low confidence (5)

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[github-actions]

❌ Integration Tests completed with failures or errors.

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

• mx-chain-go Commit Hash: 974bd33a5e0da2bd493456ab1e51463eeccbb8e7
• Current Branch: lint-issues
• mx-chain-go Target Branch: rc/supernova
• mx-chain-simulator-go Target Branch: rc/supernova
• mx-chain-testing-suite Target Branch: rc/supernova
• mx-chain-simulator-go Commit Hash: 4d71f580c8bc95ab51d831c04e786d62036761e3

🚀 Environment Variables:

• TIMESTAMP: 2025_OCTOBER_09__17_03_30
• PYTEST_EXIT_CODE: 1