Skip to content

add divided by zero check for Int64 and UInt64 #2701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add divided by zero check for Int64 and UInt64 #2701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86a3d64
add divided by zero check for Int64 and UInt64
hackwaly Sep 8, 2025
2da4e33
add panic tests
hackwaly Sep 8, 2025
24e6318
workaround for msvc
hackwaly Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions builtin/int64_js.mbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ extern "js" fn get_int64_wasm_helper() -> Int64WasmHelper =

///|
impl Div for MyInt64 with div(self : MyInt64, other : MyInt64) -> MyInt64 {
guard not(other.hi == 0 && other.lo == 0) else { panic() }
let exports = get_int64_wasm_helper()
let { hi: ahi, lo: alo } = self
let { hi: bhi, lo: blo } = other
Expand All @@ -131,6 +132,7 @@ impl Div for MyInt64 with div(self : MyInt64, other : MyInt64) -> MyInt64 {

///|
fn MyInt64::div_u(self : MyInt64, other : MyInt64) -> MyInt64 {
guard not(other.hi == 0 && other.lo == 0) else { panic() }
let exports = get_int64_wasm_helper()
let { hi: ahi, lo: alo } = self
let { hi: bhi, lo: blo } = other
Expand All @@ -141,6 +143,7 @@ fn MyInt64::div_u(self : MyInt64, other : MyInt64) -> MyInt64 {

///|
impl Mod for MyInt64 with mod(self : MyInt64, other : MyInt64) -> MyInt64 {
guard not(other.hi == 0 && other.lo == 0) else { panic() }
let exports = get_int64_wasm_helper()
let { hi: ahi, lo: alo } = self
let { hi: bhi, lo: blo } = other
Expand All @@ -151,6 +154,7 @@ impl Mod for MyInt64 with mod(self : MyInt64, other : MyInt64) -> MyInt64 {

///|
fn MyInt64::mod_u(self : MyInt64, other : MyInt64) -> MyInt64 {
guard not(other.hi == 0 && other.lo == 0) else { panic() }
let exports = get_int64_wasm_helper()
let { hi: ahi, lo: alo } = self
let { hi: bhi, lo: blo } = other
Expand Down
36 changes: 36 additions & 0 deletions builtin/int64_test.mbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7472,3 +7472,39 @@ test "grouped test for specific patterns" {
// Test for all bits set except the most significant bit
inspect(UInt64::reinterpret_as_double(0x7FFFFFFFFFFFFFFFUL), content="NaN")
}

///|
#inline(never)
fn int64_zero() -> Int64 {
0L
}

///|
#inline(never)
fn uint64_zero() -> UInt64 {
0UL
}

///|
test "panic 1L / 0L" {
let _ = 1L / int64_zero()

}

///|
test "panic 1L % 0L" {
let _ = 1L % int64_zero()

}

///|
test "panic 1UL / 0UL" {
let _ = 1UL / uint64_zero()

}

///|
test "panic 1UL % 0UL" {
let _ = 1UL % uint64_zero()

}
Loading