Skip to content

#slug should not default to _id.to_s #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#slug should not default to _id.to_s #261

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bcc3c3
#slug should not default to _id.to_s. This is inconsistent with the r…
johnnyshields Aug 4, 2021
903ea95
Merge branch 'master' into remove-default-id
johnnyshields Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/mongoid/slug.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,9 +250,7 @@ def to_param

# @return [String] the slug, or nil if the document does not have a slug.
def slug
return _slugs.last if _slugs

_id.to_s
_slugs.last if _slugs
end

def slug_builder
Expand Down